quarkus
quarkus copied to clipboard
quarkusio
Add documentation for vertx and qute integration
🎊 PR Preview 322d1126ecec9ec82e65fb028b3ad8d7c4d0cc5f has been successfully built and deployed to https://quarkus-pr-main-41558-preview.surge.sh/version/main/guides/
- Images of blog posts older than 3 months are not available.
- Newsletters older than 3 months are not available.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks for this addition. I added a few minor comments.
But that being said, I'm a bit puzzled. Why would you have
io.vertx.core.json.JsonObjectin your classpath, if you don't have thequarkus-vertxextension?At least in the Quarkus world, that seems like looking for weird issues as Vert.x won't work very well if you don't use the extension.
Could you explain how you stumbled upon this issue and why you wanted to document it?
@mkouba @geoand WDYT?
@gsmet It's a feature requested from https://github.com/quarkiverse/quarkus-roq. The idea is to add the Qute value resolver only if quarkus-vertx is on the class path. We use the same approach for quarkus-cache.
See https://github.com/quarkusio/quarkus/issues/41390 for more information.
@mkouba well, it's your component so your decision but by reading this paragraph, I'm under the impression that, as a Quarkus user, I have to do something on my side when I want to have support for JsonObject.
But, except if you are actually dealing with conditional dependencies, you actually don't need to do anything.
I think this is a bit confusing and adding complexity for something that is an advanced usage and a corner case. It's probably worth documenting it but I would clearly explain the context and when this is actually needed. Because the fact that you needed to actually explain it to me is a sign that it's easy to miss. And I'm not exactly your typical Quarkus user :).
Feel free to dismiss my review once the Vert.x typo is fixed. I might be overthinking it :).
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus Documentation CI
This is the status report for running Quarkus Documentation CI on commit 793eaba7c021a87e661b5e96d5cc8944a57e3558.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
![quarkus-bot[bot] avatar](https://avatars.githubusercontent.com/in/90234?v=4 "Published by a pub.dev verified publisher"){kind=small}
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus Documentation CI
This is the status report for running Quarkus Documentation CI on commit a52cb42887a109e4712c661cdf44d1ec92661192.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus Documentation CI
This is the status report for running Quarkus Documentation CI on commit 12eecc501bfa1d5831a7be552ea3ebb17609ab3c.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus Documentation CI
This is the status report for running Quarkus Documentation CI on commit f6e40ea45f5c63c2a3a74b88cec952f50413b19a.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus Documentation CI
This is the status report for running Quarkus Documentation CI on commit 658f3ae9d50eb8564e3a42169ca4362ba081dcde.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus Documentation CI
This is the status report for running Quarkus Documentation CI on commit f1046cebc1fc055992a6b0d9d839c782bd773493.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
Status for workflow Quarkus Documentation CI
This is the status report for running Quarkus Documentation CI on commit 8aeaed617fb29167d8655fa896e6945fb9a5657c.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.