Avoid NPE handling registry in image reference parsing

[MikeEdgar]

[quarkus-bot[bot]]

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

• title should preferably start with an uppercase character (if it makes sense!)

_{This message is automatically generated by a bot.}

[quarkus-bot[bot]]

---

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

---

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 112eee529333f5b0e7f2a7b6a67481d4ca1cf8fb.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✖	Initial JDK 17 Build	Build	Failures	Logs	Raw logs	:mag:

You can consult the Develocity build scans.

Failures

:gear: Initial JDK 17 Build #

- Failing: extensions/container-image/spi 
! Skipped: docs extensions/container-image/container-image-buildpack/deployment extensions/container-image/container-image-docker-common/deployment and 18 more

:package: extensions/container-image/spi

✖ Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.24.1:validate (default) on project quarkus-container-image-spi: File '/home/runner/work/quarkus/quarkus/extensions/container-image/spi/src/main/java/io/quarkus/container/spi/ImageReference.java' has not been previously formatted. Please format file (for example by invoking `mvn -f extensions/container-image/spi net.revelc.code.formatter:formatter-maven-plugin:2.24.1:format`) and commit before running validation!

[quarkus-bot[bot]]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9be28f5f195c90e78881ae67165f4378457fe299.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

[geoand]

Thanks for this @MikeEdgar.

I am curious whether you've checked if com.google.cloud.tools.jib.api.ImageReference (from where this class was derived) contains these guards.

[MikeEdgar]

@geoand , the JIB class does check for a null registry, but replaces it with the constant DOCKER_HUB_REGISTRY. This was also the case in Quarkus prior to #34241. With that PR, the NPE became possible when the registry is not part of the image reference.

[geoand]

Gotcha, thanks