quarkus
quarkus copied to clipboard
Fix liquibase issue with resource path
- Fixes: #41236
now it compiles successfully the native image
Thanks for your pull request!
The title of your pull request does not follow our editorial rules. Could you have a look?
- title should preferably start with an uppercase character (if it makes sense!)
- title should not contain an issue number (use
Fix #1234in the description instead)
This message is automatically generated by a bot.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit 5813d9c5d5b42bc97b76248e1850def79bc5d811.
Failing Jobs
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✖ | Initial JDK 17 Build | Build |
Failures | Logs | Raw logs | :mag: |
You can consult the Develocity build scans.
Failures
:gear: Initial JDK 17 Build #
- Failing: extensions/liquibase/deployment
! Skipped: docs integration-tests/liquibase
:package: extensions/liquibase/deployment
✖ Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.24.1:validate (default) on project quarkus-liquibase-deployment: File '/home/runner/work/quarkus/quarkus/extensions/liquibase/deployment/src/main/java/io/quarkus/liquibase/deployment/LiquibaseProcessor.java' has not been previously formatted. Please format file (for example by invoking `mvn -f extensions/liquibase/deployment net.revelc.code.formatter:formatter-maven-plugin:2.24.1:format`) and commit before running validation!
I force pushed a small formatting change to make CI happier.
@geoand I let you review this one as you already tried to fix this? I think I would like an IT there because it's not ideal to only have the quickstarts failing.
Oh and sorry, I should have started with that: thanks for the patch and taking the time to fight this issue!
I remember seeing the original issue, but not trying to fix it :)
I think I would like an IT
That would be great! @juanjogv do you mind updating the Flyway integration test to introduce this check?
@geoand sure I can do it, but it will take me a bit of time as I have no experience with IT on extensions, if that's not a problem, no biggie for me.
No problem at all