quarkus
quarkus copied to clipboard
[WIP] Upgrade to Hibernate ORM 6.6 / Search 7.2
Work in progress; I need to run tests and I suspect neither Search nor Reactive are compatible in these versions.
Based on #41358 , which must be merged first.
Here's what we will need to add to the migration guide:
== JPA / Hibernate ORM
=== Upgrade to Hibernate ORM 6.6
The Quarkus extensions for Hibernate ORM was upgraded to Hibernate ORM 6.6.
Hibernate ORM 6.6 is largely backwards-compatible with Hibernate ORM 6.5,
but a few checks have been tightened, so applications with incorrect configuration, mapping, or queries
may now throw exceptions where they used to experience only warnings and malfunctions.
In particular:
* [Merging detects invalid creation attempts](https://docs.jboss.org/hibernate/orm/6.6/migration-guide/migration-guide.html#merge-versioned-deleted):
passing to `merge` an entity with a `@GeneratedValue` identifier or a `@Version` property set to a non-null value
will now fail, whereas it used to (incorrectly) create the entity in database.
See the https://github.com/hibernate/hibernate-orm/blob/6.6/migration-guide.adoc[Hibernate ORM 6.6 migration guide] for more details.
/cc @gsmet (hibernate-orm)
Thanks for your pull request!
The title of your pull request does not follow our editorial rules. Could you have a look?
- title should preferably start with an uppercase character (if it makes sense!)
This message is automatically generated by a bot.
🎊 PR Preview c24efa87a6be502deb7ec009d28688b0ad561452 has been successfully built and deployed to https://quarkus-pr-main-41359-preview.surge.sh/version/main/guides/
- Images of blog posts older than 3 months are not available.
- Newsletters older than 3 months are not available.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit 8737cedf2cdb58cd93af050625d9cce60ef01d44.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
You can consult the Develocity build scans.
Flaky tests - Develocity
:gear: JVM Tests - JDK 17
:package: integration-tests/opentelemetry
✖ io.quarkus.it.opentelemetry.MetricsTest.directCounterTest - History
Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds.-org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds.
at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
at io.quarkus.it.opentelemetry.MetricsTest.directCounterTest(MetricsTest.java:54)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
:gear: JVM Tests - JDK 21
:package: integration-tests/opentelemetry
✖ io.quarkus.it.opentelemetry.MetricsTest.directCounterTest - History
Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds.-org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds.
at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
at io.quarkus.it.opentelemetry.MetricsTest.directCounterTest(MetricsTest.java:54)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
:gear: Native Tests - HTTP
:package: integration-tests/rest-client-reactive
✖ io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans - History
expected: <1> but was: <2>-org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:821)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
I rebased, updated to the Final versions and force pushed.
thanks! 🎉
I added the content written by Yoann to the migration guide.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit 09706de2ee258aada79993cea7b1b4f3ab42c22b.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
You can consult the Develocity build scans.