quarkus
quarkus copied to clipboard
Observability Dev UI Card and Log Console
Fix #41241
Adds DEVUI card and Console logger for the LGTM in the Dev UI.
Card
Log console:
/cc @cescoffier (devui), @phillip-kruger (devui)
@brunobat I just pre-emptively updated the PR to use the two new property names for grafana.endpoint and otel-collector.url
Excellent. Will make my best to make it available today.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit 24ba713398f40db205893117d52cf56e746b668a.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
You can consult the Develocity build scans.
Just a question for now, what do we do with these DevUI cards, when we add / have more then just LGTM? One for each, or a joined card ... ?
Up to you! We can create the Card as "LGTM" instead of "Observability" etc.
We can create many cards or 1 single card with many values.
Would you prefer I rename this card "LGTM" ?
@alesj check this out. @phillip-kruger it won't let me rename the Card Title it looks like it always uses the extension name? So if one extension were to produce many cards they would all have the same name I think?
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit 1c8bf754e35fddddaab579d98c83b6c96e4a0bfe.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
You can consult the Develocity build scans.
Every extension get's one card. (Else we might have too many cards). You can create multiple pages (sub menus in the maxi view of a card)
Thanks @phillip-kruger that makes sense.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit 42616ae66118e2df15bf78b5b91456c1e2cd1c72.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
You can consult the Develocity build scans.
@brunobat i merged your changes from your recently accepted PR but it won't let me squash them now?
You should have rebased...
I made the mistake of fixing a merge conflict in the GitHub editor and that does a merge instead of rebase
@brunobat i fixed it back to a squash commit!
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus Documentation CI
This is the status report for running Quarkus Documentation CI on commit eaba7fd2dcea22bed6bff6c45581601311ac6364.
Failing Jobs
:warning: Artifacts of the workflow run were not available thus the report misses some details.
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✖ | Documentation Build | Build |
:warning: Check → | Logs | Raw logs | :construction: |
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit eaba7fd2dcea22bed6bff6c45581601311ac6364.
Failing Jobs
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✖ | Initial JDK 17 Build | Build |
Failures | Logs | Raw logs | :mag: |
You can consult the Develocity build scans.
Failures
:gear: Initial JDK 17 Build #
- Failing: extensions/observability-devservices/deployment
! Skipped: docs
:package: extensions/observability-devservices/deployment
✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project quarkus-observability-devservices-deployment: Compilation failure
/home/runner/work/quarkus/quarkus/extensions/observability-devservices/deployment/src/main/java/io/quarkus/observability/deployment/ObservabilityDevServiceProcessor.java:[166,17] cannot find symbol
symbol: variable configBuildProducer
location: class io.quarkus.observability.deployment.ObservabilityDevServiceProcessor
Docs updated
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit 027b565212ba90bfe3c162ed2f66eccaebae3c90.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
[!WARNING] There are other workflow runs running, you probably need to wait for their status before merging.
You can consult the Develocity build scans.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus Documentation CI
This is the status report for running Quarkus Documentation CI on commit 027b565212ba90bfe3c162ed2f66eccaebae3c90.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
I tested the PR on a local project and I found a few problems:
- We were missing the new Metrics signal... I created this PR to fix the issue: https://github.com/quarkusio/quarkus/pull/41903
- There are resources that should be registered in order not to be tracked in the traces. I imagine these are new static resources. See:
- The PR I created above seems to break the card. See:
@phillip-kruger didn't we run into something like before where static resources were breaking the resolving of the card?
@phillip-kruger didn't we run into something like before where static resources were breaking the resolving of the card?
Yes, if the extension has it's own web resources that also use WebJarBuildItem. Is that the case here ?
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit 8e2682cd9e30f6d09b96e7bf01e639a603ab6e1d.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
[!WARNING] There are other workflow runs running, you probably need to wait for their status before merging.
You can consult the Develocity build scans.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus Documentation CI
This is the status report for running Quarkus Documentation CI on commit 8e2682cd9e30f6d09b96e7bf01e639a603ab6e1d.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit 5a60c968c4d2049edc392bfa92ea3e8864e8331c.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
[!WARNING] There are other workflow runs running, you probably need to wait for their status before merging.
You can consult the Develocity build scans.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus Documentation CI
This is the status report for running Quarkus Documentation CI on commit 5a60c968c4d2049edc392bfa92ea3e8864e8331c.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
What's the status of this?
IMHO this is a really good usability improvement
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit fd3672230e91cfa8e530f39c4f15e03351bdd61c.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
[!WARNING] There are other workflow runs running, you probably need to wait for their status before merging.
You can consult the Develocity build scans.