quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

Published 20 hours ago • verified publisher icon quarkusio

Improve Config CLI

Open radcortez opened this issue 1 year ago • 11 comments

Fixes #41131

  • Properly add help flags
  • Moved required options to parameters
  • Add a remove command

radcortez avatar Jun 14 '24 10:06 radcortez

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5fe2434d86e4c32d9afcf58f7ba90b5a249ae899.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

quarkus-bot[bot] avatar Jun 14 '24 12:06 quarkus-bot[bot]

Ah cool, I tried it the other day and it was a bit hard to use. I'll have a look soon.

gsmet avatar Jun 14 '24 15:06 gsmet

Should be easier now :)

radcortez avatar Jun 14 '24 16:06 radcortez

I'm having a look at it now.

gsmet avatar Jun 27 '24 12:06 gsmet

  1. I think quarkus config should display the help rather than defaulting to set. For me this is too important to push a random default.

OK

  1. I think the feedback should be consistent with the feedback we have when adding an extension for instance.

In general, we should try to be consistent on the feedback side.

OK

  1. When typing quarkus config enc, I end up with an error instead of the help being displaying (this is the case in main but also in this branch). I created Picocli - Some expected errors lead to a stacktrace and they shouldn't #41513 because even if you can tweak it here, I think it's something that is not ideal in our Picocli extension.

Yes, this is an issue with our extension rather than the CLI commands. When I looked into other examples, we also got the same error (for instance, quarkus extension add without any parameter also ends up with a stacktrace). I then forgot to open an issue about it. Thanks for opening one. It seems this happens only with subcommands.

  1. I'm not sure of why I have to pass the secret with --secret in quarkus config enc --secret=secret, for the rest you pass the parameters as is (or at least that's what I did and it worked).

Strange. It shouldn't be that way anymore. The previous version did have a --secret option but I've changed that to be a parameter.

Also I have no idea what to do with the output:

Encrypted Secret: DBLLBaf7o_i3u8lmJBb0rKJT13xvBXoQYjVFWFCJACl_tGU
Encryption Key: S6i5aNG6ySALS6021eMKbg

We probably need to explain what to do with it?

OK

radcortez avatar Jun 28 '24 09:06 radcortez

This is how it is looking now:

Screenshot 2024-06-28 at 12 47 32

radcortez avatar Jun 28 '24 11:06 radcortez

Love it!

gsmet avatar Jun 28 '24 12:06 gsmet

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f4713240f96b553a589728bd9e769233abd94031.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
:heavy_check_mark: JVM Tests - JDK 17 Logs Raw logs :mag:
:heavy_check_mark: JVM Tests - JDK 21 Logs Raw logs :mag:
✖ JVM Tests - JDK 17 Windows Build Failures Logs Raw logs :mag:

Full information is available in the Build summary check run. You can consult the Develocity build scans.

Failures

:gear: JVM Tests - JDK 17 Windows #

- Failing: devtools/cli

:package: devtools/cli

✖ io.quarkus.cli.config.EncryptTest.encrypt line 25 - History - More details - Source on GitHub

java.lang.ArrayIndexOutOfBoundsException: Index 16 out of bounds for length 16
	at io.quarkus.cli.config.EncryptTest.encrypt(EncryptTest.java:25)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

✖ io.quarkus.cli.config.EncryptTest.keyBase64 line 70 - History - More details - Source on GitHub

java.lang.ArrayIndexOutOfBoundsException: Index 9 out of bounds for length 9
	at io.quarkus.cli.config.EncryptTest.keyBase64(EncryptTest.java:70)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

✖ io.quarkus.cli.config.EncryptTest.keyPlain line 43 - History - More details - Source on GitHub

java.lang.ArrayIndexOutOfBoundsException: Index 9 out of bounds for length 9
	at io.quarkus.cli.config.EncryptTest.keyPlain(EncryptTest.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

✖ io.quarkus.cli.config.RemoveConfigTest.removeConfiguration line 45 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.cli.config.RemoveConfigTest.removeConfiguration(RemoveConfigTest.java:45)

✖ io.quarkus.cli.config.SetConfigTest.addConfiguration line 37 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.cli.config.SetConfigTest.addConfiguration(SetConfigTest.java:37)

✖ io.quarkus.cli.config.SetConfigTest.addEncryptedConfiguration line 62 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.cli.config.SetConfigTest.addEncryptedConfiguration(SetConfigTest.java:62)

✖ io.quarkus.cli.config.SetConfigTest.setConfiguration line 54 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.cli.config.SetConfigTest.setConfiguration(SetConfigTest.java:54)

quarkus-bot[bot] avatar Jun 28 '24 12:06 quarkus-bot[bot]

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4aa319925f08d90ebd94a558d00eabc9ecd6bca6.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
:heavy_check_mark: JVM Tests - JDK 17 Logs Raw logs :mag:
:heavy_check_mark: JVM Tests - JDK 21 Logs Raw logs :mag:
✖ JVM Tests - JDK 17 Windows Build Failures Logs Raw logs :mag:

Full information is available in the Build summary check run. You can consult the Develocity build scans.

Failures

:gear: JVM Tests - JDK 17 Windows #

- Failing: devtools/cli

:package: devtools/cli

✖ io.quarkus.cli.config.EncryptTest.encrypt line 34 - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.IllegalArgumentException: Illegal base64 character 1b
	at io.smallrye.config.crypto.AESGCMNoPaddingSecretKeysHandler.decode(AESGCMNoPaddingSecretKeysHandler.java:44)
	at io.smallrye.config.ExpressionConfigSourceInterceptor$1.accept(ExpressionConfigSourceInterceptor.java:79)
	at io.smallrye.config.ExpressionConfigSourceInterceptor$1.accept(ExpressionConfigSourceInterceptor.java:71)
	at io.smallrye.common.expression.ExpressionNode.emit(ExpressionNode.java:22)
	at io.smallrye.common.expression.Expression.evaluateException(Expression.java:56)
	at io.smallrye.common.expression.Expression.evaluate(Expression.java:70)
	at io.smallrye.config.ExpressionConfigSourceInterceptor.getValue(ExpressionConfigSourceInterceptor.java:71)

✖ io.quarkus.cli.config.EncryptTest.keyBase64 line 79 - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.IllegalArgumentException: Illegal base64 character 1b
	at io.smallrye.config.crypto.AESGCMNoPaddingSecretKeysHandler.decode(AESGCMNoPaddingSecretKeysHandler.java:44)
	at io.smallrye.config.ExpressionConfigSourceInterceptor$1.accept(ExpressionConfigSourceInterceptor.java:79)
	at io.smallrye.config.ExpressionConfigSourceInterceptor$1.accept(ExpressionConfigSourceInterceptor.java:71)
	at io.smallrye.common.expression.ExpressionNode.emit(ExpressionNode.java:22)
	at io.smallrye.common.expression.Expression.evaluateException(Expression.java:56)
	at io.smallrye.common.expression.Expression.evaluate(Expression.java:70)
	at io.smallrye.config.ExpressionConfigSourceInterceptor.getValue(ExpressionConfigSourceInterceptor.java:71)

✖ io.quarkus.cli.config.EncryptTest.keyPlain line 52 - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.IllegalArgumentException: Illegal base64 character 1b
	at io.smallrye.config.crypto.AESGCMNoPaddingSecretKeysHandler.decode(AESGCMNoPaddingSecretKeysHandler.java:44)
	at io.smallrye.config.ExpressionConfigSourceInterceptor$1.accept(ExpressionConfigSourceInterceptor.java:79)
	at io.smallrye.config.ExpressionConfigSourceInterceptor$1.accept(ExpressionConfigSourceInterceptor.java:71)
	at io.smallrye.common.expression.ExpressionNode.emit(ExpressionNode.java:22)
	at io.smallrye.common.expression.Expression.evaluateException(Expression.java:56)
	at io.smallrye.common.expression.Expression.evaluate(Expression.java:70)
	at io.smallrye.config.ExpressionConfigSourceInterceptor.getValue(ExpressionConfigSourceInterceptor.java:71)

✖ io.quarkus.cli.config.RemoveConfigTest.removeConfiguration line 45 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.cli.config.RemoveConfigTest.removeConfiguration(RemoveConfigTest.java:45)

✖ io.quarkus.cli.config.SetConfigTest.addConfiguration line 37 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.cli.config.SetConfigTest.addConfiguration(SetConfigTest.java:37)

✖ io.quarkus.cli.config.SetConfigTest.addEncryptedConfiguration line 62 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.cli.config.SetConfigTest.addEncryptedConfiguration(SetConfigTest.java:62)

✖ io.quarkus.cli.config.SetConfigTest.setConfiguration line 54 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.cli.config.SetConfigTest.setConfiguration(SetConfigTest.java:54)

quarkus-bot[bot] avatar Jun 28 '24 15:06 quarkus-bot[bot]

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit da0dfc46cb0220945a1596d8f8755705ed989912.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
:heavy_check_mark: JVM Tests - JDK 17 Logs Raw logs :mag:
:heavy_check_mark: JVM Tests - JDK 21 Logs Raw logs :mag:
✖ JVM Tests - JDK 17 Windows Build Failures Logs Raw logs :mag:

Full information is available in the Build summary check run. You can consult the Develocity build scans.

Failures

:gear: JVM Tests - JDK 17 Windows #

- Failing: devtools/cli

:package: devtools/cli

✖ io.quarkus.cli.config.EncryptTest.encrypt line 35 - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.IllegalArgumentException: Illegal base64 character 1b
	at io.smallrye.config.crypto.AESGCMNoPaddingSecretKeysHandler.decode(AESGCMNoPaddingSecretKeysHandler.java:44)
	at io.smallrye.config.ExpressionConfigSourceInterceptor$1.accept(ExpressionConfigSourceInterceptor.java:79)
	at io.smallrye.config.ExpressionConfigSourceInterceptor$1.accept(ExpressionConfigSourceInterceptor.java:71)
	at io.smallrye.common.expression.ExpressionNode.emit(ExpressionNode.java:22)
	at io.smallrye.common.expression.Expression.evaluateException(Expression.java:56)
	at io.smallrye.common.expression.Expression.evaluate(Expression.java:70)
	at io.smallrye.config.ExpressionConfigSourceInterceptor.getValue(ExpressionConfigSourceInterceptor.java:71)

✖ io.quarkus.cli.config.EncryptTest.keyBase64 line 82 - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.IllegalArgumentException: Illegal base64 character 1b
	at io.smallrye.config.crypto.AESGCMNoPaddingSecretKeysHandler.decode(AESGCMNoPaddingSecretKeysHandler.java:44)
	at io.smallrye.config.ExpressionConfigSourceInterceptor$1.accept(ExpressionConfigSourceInterceptor.java:79)
	at io.smallrye.config.ExpressionConfigSourceInterceptor$1.accept(ExpressionConfigSourceInterceptor.java:71)
	at io.smallrye.common.expression.ExpressionNode.emit(ExpressionNode.java:22)
	at io.smallrye.common.expression.Expression.evaluateException(Expression.java:56)
	at io.smallrye.common.expression.Expression.evaluate(Expression.java:70)
	at io.smallrye.config.ExpressionConfigSourceInterceptor.getValue(ExpressionConfigSourceInterceptor.java:71)

✖ io.quarkus.cli.config.EncryptTest.keyPlain line 54 - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.IllegalArgumentException: Illegal base64 character 1b
	at io.smallrye.config.crypto.AESGCMNoPaddingSecretKeysHandler.decode(AESGCMNoPaddingSecretKeysHandler.java:44)
	at io.smallrye.config.ExpressionConfigSourceInterceptor$1.accept(ExpressionConfigSourceInterceptor.java:79)
	at io.smallrye.config.ExpressionConfigSourceInterceptor$1.accept(ExpressionConfigSourceInterceptor.java:71)
	at io.smallrye.common.expression.ExpressionNode.emit(ExpressionNode.java:22)
	at io.smallrye.common.expression.Expression.evaluateException(Expression.java:56)
	at io.smallrye.common.expression.Expression.evaluate(Expression.java:70)
	at io.smallrye.config.ExpressionConfigSourceInterceptor.getValue(ExpressionConfigSourceInterceptor.java:71)

✖ io.quarkus.cli.config.RemoveConfigTest.removeConfiguration line 45 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.cli.config.RemoveConfigTest.removeConfiguration(RemoveConfigTest.java:45)

quarkus-bot[bot] avatar Jun 28 '24 16:06 quarkus-bot[bot]

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit da0dfc46cb0220945a1596d8f8755705ed989912.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
:heavy_check_mark: JVM Tests - JDK 17 Logs Raw logs :mag:
:heavy_check_mark: JVM Tests - JDK 21 Logs Raw logs :mag:
✖ JVM Tests - JDK 17 Windows Build Failures Logs Raw logs :mag:

Full information is available in the Build summary check run. You can consult the Develocity build scans.

Failures

:gear: JVM Tests - JDK 17 Windows #

- Failing: devtools/cli

:package: devtools/cli

✖ io.quarkus.cli.config.EncryptTest.encrypt line 35 - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.IllegalArgumentException: Illegal base64 character 1b
	at io.smallrye.config.crypto.AESGCMNoPaddingSecretKeysHandler.decode(AESGCMNoPaddingSecretKeysHandler.java:44)
	at io.smallrye.config.ExpressionConfigSourceInterceptor$1.accept(ExpressionConfigSourceInterceptor.java:79)
	at io.smallrye.config.ExpressionConfigSourceInterceptor$1.accept(ExpressionConfigSourceInterceptor.java:71)
	at io.smallrye.common.expression.ExpressionNode.emit(ExpressionNode.java:22)
	at io.smallrye.common.expression.Expression.evaluateException(Expression.java:56)
	at io.smallrye.common.expression.Expression.evaluate(Expression.java:70)
	at io.smallrye.config.ExpressionConfigSourceInterceptor.getValue(ExpressionConfigSourceInterceptor.java:71)

✖ io.quarkus.cli.config.EncryptTest.keyBase64 line 82 - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.IllegalArgumentException: Illegal base64 character 1b
	at io.smallrye.config.crypto.AESGCMNoPaddingSecretKeysHandler.decode(AESGCMNoPaddingSecretKeysHandler.java:44)
	at io.smallrye.config.ExpressionConfigSourceInterceptor$1.accept(ExpressionConfigSourceInterceptor.java:79)
	at io.smallrye.config.ExpressionConfigSourceInterceptor$1.accept(ExpressionConfigSourceInterceptor.java:71)
	at io.smallrye.common.expression.ExpressionNode.emit(ExpressionNode.java:22)
	at io.smallrye.common.expression.Expression.evaluateException(Expression.java:56)
	at io.smallrye.common.expression.Expression.evaluate(Expression.java:70)
	at io.smallrye.config.ExpressionConfigSourceInterceptor.getValue(ExpressionConfigSourceInterceptor.java:71)

✖ io.quarkus.cli.config.EncryptTest.keyPlain line 54 - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.IllegalArgumentException: Illegal base64 character 1b
	at io.smallrye.config.crypto.AESGCMNoPaddingSecretKeysHandler.decode(AESGCMNoPaddingSecretKeysHandler.java:44)
	at io.smallrye.config.ExpressionConfigSourceInterceptor$1.accept(ExpressionConfigSourceInterceptor.java:79)
	at io.smallrye.config.ExpressionConfigSourceInterceptor$1.accept(ExpressionConfigSourceInterceptor.java:71)
	at io.smallrye.common.expression.ExpressionNode.emit(ExpressionNode.java:22)
	at io.smallrye.common.expression.Expression.evaluateException(Expression.java:56)
	at io.smallrye.common.expression.Expression.evaluate(Expression.java:70)
	at io.smallrye.config.ExpressionConfigSourceInterceptor.getValue(ExpressionConfigSourceInterceptor.java:71)

✖ io.quarkus.cli.config.RemoveConfigTest.removeConfiguration line 45 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.cli.config.RemoveConfigTest.removeConfiguration(RemoveConfigTest.java:45)

quarkus-bot[bot] avatar Jun 29 '24 10:06 quarkus-bot[bot]

Some changes here (Moved required options to parameters: SECRET, NAME, VALUE) are not backwards compatible, but I can't find it documented in https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.13 and this PR does not have a breaking-change label. Can you improve this, please?

michalvavrik avatar Jul 25 '24 18:07 michalvavrik

Hey @michalvavrik sorry for the inconvenience.

We made the changes to fix some of the raised issues, plus make it consistent with other Quarkus CLI commands. I'll add that information now.

radcortez avatar Jul 26 '24 13:07 radcortez

Hey @michalvavrik sorry for the inconvenience.

We made the changes to fix some of the raised issues, plus make it consistent with other Quarkus CLI commands. I'll add that information now.

np, but good to have it documented, thanks

michalvavrik avatar Jul 26 '24 13:07 michalvavrik

https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.13#quarkus-cli

radcortez avatar Jul 26 '24 14:07 radcortez