quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

Always populate metrics uri in presence of auth failures

Open geoand opened this issue 1 year ago • 4 comments

  • Fixes: #40305

geoand avatar Apr 26 '24 13:04 geoand

The reason I have not added a test is that surfacing the problem requires a different security setup than the one of the existing integration tests and I am not terribly happy about adding yet another maven module. If we do think it's important however, I can go ahead and add it.

geoand avatar Apr 26 '24 13:04 geoand

The reason I have not added a test is that surfacing the problem requires a different security setup than the one of the existing integration tests and I am not terribly happy about adding yet another maven module. If we do think it's important however, I can go ahead and add it.

It would be nice to find someway to exercise the code path, especially as it is rare (and we're less likely to notice if we break it). This could mean that we should think about a different way to test security paths altogether.

ebullient avatar Apr 26 '24 15:04 ebullient


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 6ad9664859bceda478d5ab1c6fa8abd175306438.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

:gear: JVM Tests - JDK 21

:package: extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

quarkus-bot[bot] avatar Apr 26 '24 16:04 quarkus-bot[bot]

The reason I have not added a test is that surfacing the problem requires a different security setup than the one of the existing integration tests and I am not terribly happy about adding yet another maven module. If we do think it's important however, I can go ahead and add it.

It would be nice to find someway to exercise the code path, especially as it is rare (and we're less likely to notice if we break it). This could mean that we should think about a different way to test security paths altogether.

The only way is to add another integration test module

geoand avatar Apr 26 '24 16:04 geoand

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit dcbcdbdbe4164fda0717e171a56d2b7981cfd5fc.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

quarkus-bot[bot] avatar Apr 29 '24 08:04 quarkus-bot[bot]