quarkus
                                
                                 quarkus copied to clipboard
                                
                                    quarkus copied to clipboard
                            
                            
                            
                        Add mongo commands to otel span attributes
Solving https://github.com/quarkusio/quarkus/issues/28473
A simple approach to add mongo commands to traces using CommandListener. Similar approach as it was in quarkus-opentracing but without relying on https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/mongo/mongo-3.1/library, but using the similiar though simpler code.
Thanks for your pull request!
The title of your pull request does not follow our editorial rules. Could you have a look?
- title should preferably start with an uppercase character (if it makes sense!)
This message is automatically generated by a bot.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit 8e551cf1da160635a24e6d2aff44f5ee66f81d35.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
You can consult the Develocity build scans.
Will also fix https://github.com/quarkusio/quarkus/pull/40191
Status for workflow Quarkus CI
This is the status report for running Quarkus CI on commit 6d35887d8ea26776787401a4e3064b223bfc81fe.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
You can consult the Develocity build scans.
This is interesting. I wonder if we can add the same telemetry support to ORM and HR/Panache static methods.
Was on PTO and only now I saw this... The implementation should have been made in the OTel extension and not in the Mongo db one... MongoDB should not depend on OTel. All other instrumentations work like that.
@vkn are you available to refactor the code in that way?
Also we lack documentation entries and additional IT tests for Uni, Multi, parent-child relationships and failure cases.
Also, the assertions need to verify the attributes of the spans.
@vkn are you available to refactor the code in that way?
@brunobat yes