quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

@RunOnVertxContext incompatible with @ParameterizedTest

Open leslion opened this issue 1 year ago • 2 comments

Hi,

This is a follow up of the discussion #34222. I have the exact same scenario as described in that issue.

Is there an upcoming fix for the incompatibility between @RunOnVertxContext and @ParameterizedTest?

leslion avatar Mar 27 '24 19:03 leslion

@mkouba I've no idea what it would mean in practice. I'm actually not sure @ParameterizedTests are well supported in @QuarkusTest. Maybe when using @QuarkusUnitTest.

cescoffier avatar Oct 18 '24 06:10 cescoffier

I'm actually not sure @ParameterizedTests are well supported in @QuarkusTest.

It is not. We will have to revisit the io.quarkus.test.TestMethodInvoker SPI because currently only one invoker is supported and it has to handle all the method params. Morever, we do not use io.quarkus.test.TestMethodInvokers for test template methods (such as @RepeatedTest or @ParameterizedTest (in both @QuarkusTest and QuarkusUnitTest). I have no idea why. See also my comment here: https://github.com/quarkusio/quarkus/issues/24590#issuecomment-2407004451.

mkouba avatar Oct 18 '24 08:10 mkouba

@mkouba should we close all these issues as won't fix, or do you believe there is a near future hope. (Closing does not mean it won't be done, just that it's not going to be done soon).

cescoffier avatar Oct 21 '24 06:10 cescoffier

@mkouba should we close all these issues as won't fix, or do you believe there is a near future hope. (Closing does not mean it won't be done, just that it's not going to be done soon).

I'm not sure to be honest. We should ask the TestMethodInvoker SPI authors first ;-).

CC @FroMage @geoand

mkouba avatar Oct 21 '24 07:10 mkouba

Yeah, let's close for now. The only way I see us revisiting this is if the work @holly-cummins is doing around the test CL fixes our main CL woes, so we can then focus on improving SPIs like this one.

geoand avatar Oct 21 '24 07:10 geoand