quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

Allow disabling Jackson ObjectMapper WRITE_DURATIONS_AS_TIMESTAMPS

Open davidfrickert opened this issue 3 years ago • 8 comments

Fixes #28605

davidfrickert avatar Oct 15 '22 16:10 davidfrickert

I opted to set the default config the same that is provided by Jackson - which is to serialize Durations as Timestamps - in order to not break existing Quarkus applications that are using the default value.

davidfrickert avatar Oct 15 '22 16:10 davidfrickert


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building 1231db6969ab66330801e3cf4bcdea93372ced06

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

:gear: Initial JDK 11 Build #

- Failing: extensions/jackson/deployment 
! Skipped: devtools/bom-descriptor-json devtools/cli docs and 306 more

:package: extensions/jackson/deployment

Failed to execute goal net.revelc.code:impsort-maven-plugin:1.7.0:check (check-imports) on project quarkus-jackson-deployment: Imports are not sorted in /home/runner/work/quarkus/quarkus/extensions/jackson/deployment/src/test/java/io/quarkus/jackson/deployment/JacksonWriteDurationsAsTimestampsDisabledTest.java

quarkus-bot[bot] avatar Oct 15 '22 17:10 quarkus-bot[bot]


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building bc3681e72c7516a0dc76b34aa26e620012c94fd1

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

:gear: Initial JDK 11 Build #

- Failing: extensions/jackson/deployment 
! Skipped: devtools/bom-descriptor-json devtools/cli docs and 306 more

:package: extensions/jackson/deployment

Failed to execute goal net.revelc.code:impsort-maven-plugin:1.7.0:check (check-imports) on project quarkus-jackson-deployment: Imports are not sorted in /home/runner/work/quarkus/quarkus/extensions/jackson/deployment/src/test/java/io/quarkus/jackson/deployment/JacksonWriteDurationsAsTimestampsDisabledTest.java

quarkus-bot[bot] avatar Oct 15 '22 17:10 quarkus-bot[bot]

It seems I missed the Intellij IDEA configuration part of the import order file. Going to install it and fix the import order of the tests.

davidfrickert avatar Oct 15 '22 17:10 davidfrickert

Just run mvn process-sources.

gsmet avatar Oct 15 '22 18:10 gsmet

Also please squash all the commits when you're done.

gsmet avatar Oct 15 '22 18:10 gsmet

Thanks for the tip @gsmet. I ended up installing the plugin and fixing the imports with it. Also did a force push with a single commit. Just ran mvn process-sources and it didn't perform any changes so it should be good now.

davidfrickert avatar Oct 15 '22 18:10 davidfrickert


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building 35d96aeba95add219fd7d5e92c1b4e5815c2294a

Status Name Step Failures Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 17 MacOS M1
:heavy_check_mark: JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

:gear: JVM Tests - JDK 11 Windows #

- Failing: extensions/reactive-routes/deployment 
! Skipped: extensions/avro/deployment extensions/hibernate-search-orm-coordination-outbox-polling/deployment extensions/keycloak-admin-client-reactive/deployment and 88 more

:package: extensions/reactive-routes/deployment

io.quarkus.vertx.web.context.DuplicatedContextTest.testThatRoutesAreCalledOnDuplicatedContext line 58 - More details - Source on GitHub

io.smallrye.mutiny.TimeoutException
	at io.smallrye.mutiny.operators.uni.UniBlockingAwait.await(UniBlockingAwait.java:64)
	at io.smallrye.mutiny.groups.UniAwait.atMost(UniAwait.java:65)

:gear: JVM Tests - JDK 17 #

- Failing: extensions/flyway/deployment 
! Skipped: integration-tests/flyway integration-tests/hibernate-orm-tenancy/datasource integration-tests/hibernate-orm-tenancy/schema and 1 more

:package: extensions/flyway/deployment

io.quarkus.flyway.test.FlywayExtensionInitSqlTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:689)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$12(ClassBasedTestDescriptor.java:395)

quarkus-bot[bot] avatar Oct 16 '22 01:10 quarkus-bot[bot]