quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

Use an enum for package type

Open nderwin opened this issue 3 years ago • 5 comments

  • converted the string constants to enum values with an attribute set to the current string value
  • updated the javadoc for LEGACY so that the generated quarkus-all-config.adoc file contains a tooltip with the deprecation info

Signed-off-by:Nathan Erwin [email protected]

nderwin avatar Oct 13 '22 20:10 nderwin

The generated all-config.html now shows this:

image

nderwin avatar Oct 13 '22 20:10 nderwin

This PR is related to #12601.

nderwin avatar Oct 14 '22 01:10 nderwin

This sounds like a good idea, thanks. Let's see what CI has to say.

gsmet avatar Oct 15 '22 17:10 gsmet

This sounds like a good idea, thanks. Let's see what CI has to say.

It's been inconsistent, but here's hoping the latest runs will be happy. :crossed_fingers:

nderwin avatar Oct 15 '22 19:10 nderwin


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building 870e1edccabbadedd2c52c1cec35734d2a41ffa6

Status Name Step Failures Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 11
:hourglass: JVM Tests - JDK 17 Build :warning: Check → Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 17 MacOS M1
:heavy_check_mark: JVM Tests - JDK 18

quarkus-bot[bot] avatar Oct 15 '22 22:10 quarkus-bot[bot]


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building 156cc744568b27a37acec5b9701a310cd102f394

Status Name Step Failures Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 11
:heavy_check_mark: JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Build Failures Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

:gear: JVM Tests - JDK 17 MacOS M1 #

- Failing: extensions/vertx/deployment 
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 340 more

:package: extensions/vertx/deployment

io.quarkus.vertx.DuplicatedContextTest.testThatBlockingEventConsumersAreCalledOnDuplicatedContext - More details - Source on GitHub

(RECIPIENT_FAILURE,8185) java.util.concurrent.CompletionException: io.netty.channel.AbstractChannel$AnnotatedSocketException: Connection reset by peer: localhost/127.0.0.1:8082
	at io.vertx.core.eventbus.Message.fail(Message.java:141)
	at io.quarkus.vertx.runtime.VertxRecorder$3$1$1.handle(VertxRecorder.java:122)

quarkus-bot[bot] avatar Oct 18 '22 05:10 quarkus-bot[bot]

@aloubyansky Fair enough; I've updated the PR based on your feedback. I agree about how much value there is with having the enum at this point, so if that needs to go away that's fine with me.

nderwin avatar Oct 18 '22 19:10 nderwin

Sorry about the re-re-re-requests for review, github is not behaving as I would expect.

nderwin avatar Oct 18 '22 19:10 nderwin


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building 23252b655a12c357f99fcce868a3954016d068a4

Status Name Step Failures Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner :warning: Check → Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

:gear: JVM Tests - JDK 11 Windows #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: extensions/keycloak-admin-client-reactive/deployment extensions/oidc-client-reactive-filter/deployment extensions/oidc-token-propagation-reactive/deployment and 17 more

:package: extensions/resteasy-reactive/rest-client-reactive/deployment

io.quarkus.rest.client.reactive.timeout.BuilderReadTimeoutTest.shouldNotTimeoutOnFastResponse line 53 - More details - Source on GitHub

javax.ws.rs.ProcessingException: The timeout period of 1000ms has been exceeded while executing GET /fast for server localhost:8081
	at org.jboss.resteasy.reactive.client.impl.InvocationBuilderImpl.unwrap(InvocationBuilderImpl.java:223)
	at org.jboss.resteasy.reactive.client.impl.InvocationBuilderImpl.method(InvocationBuilderImpl.java:324)

quarkus-bot[bot] avatar Nov 07 '22 14:11 quarkus-bot[bot]


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building 57253ddfc68ad43270cd4df6de93a80a90b77a29

Status Name Step Failures Logs Raw logs
Devtools Tests - JDK 11 Build Failures Logs Raw logs
:heavy_check_mark: Devtools Tests - JDK 11 Windows
Devtools Tests - JDK 17 Build Failures Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 11
:heavy_check_mark: JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Build Failures Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 18
:heavy_check_mark: Maven Tests - JDK 11
:hourglass: Maven Tests - JDK 11 Windows Build :warning: Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

:gear: Devtools Tests - JDK 11 #

- Failing: integration-tests/devtools 

:package: integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[1] line 81 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[1] line 81 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

:gear: Devtools Tests - JDK 17 #

- Failing: integration-tests/devtools 

:package: integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[1] line 81 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[1] line 81 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

:gear: JVM Tests - JDK 17 MacOS M1 #

- Failing: extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment integration-tests/mailer 
! Skipped: extensions/avro/deployment extensions/csrf-reactive/deployment extensions/grpc/deployment and 121 more

:package: extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment

io.quarkus.resteasy.reactive.server.test.RequestLeakDetectionTest.testWithConcurrentBlockingCalls line 70 - More details - Source on GitHub

java.lang.IllegalAccessException: class org.codehaus.groovy.reflection.CachedMethod cannot access a member of class io.restassured.internal.RequestSpecificationImpl with modifiers "private"
	at java.base/jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:392)
	at java.base/java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:674)

:package: integration-tests/mailer

io.quarkus.it.mailer.MailerTest.sendHtmlEmail - More details - Source on GitHub

java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:625)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:696)

quarkus-bot[bot] avatar Nov 07 '22 20:11 quarkus-bot[bot]

@nderwin can you rebase with the latest main to trigger CI again?

gastaldi avatar Jan 18 '23 15:01 gastaldi

@gastaldi Done; now we play the waiting game...

nderwin avatar Jan 18 '23 17:01 nderwin

Failing Jobs - Building 700fb0c4159e77316b591202c1e7c096b83a0001

Status Name Step Failures Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 11
:hourglass: JVM Tests - JDK 17 Build :warning: Check → Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 18

quarkus-bot[bot] avatar Jan 19 '23 00:01 quarkus-bot[bot]