quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

Funqy Knative Events - EventAttribute is not documented

Open michalvavrik opened this issue 3 years ago • 1 comments

Description

There is not a single reference of @EventAttribute in documentation and JavaDoc is terse: If there is an extra requirement to match against cloud event attributes to find the function to be triggered Documentation should provide a usage example and cover (among others) following:

  • Can I define custom CloudEvent attribute or just standard attributes?
  • Show my how I can curl this (that's prefix the attribute with ce- even custom one)
  • Is there logical AND or OR between @EventAttributes?
  • What happens when there is more than one function with same trigger and filter (attributes)? Is it allowed?
  • Allowed characters for EventAttribute name, as when I use dashes there, result is always bad request, f.e. @EventAttribute(name = "not-matched-name", value = "not-matched-value") won't get matched for header ce-not-matched-name: not-matched-value but it's camel case equivalent does.

WithAttributeFilterTest.java provides answers, but it's not user-friendly to infer expected behavior from 17 tests (and there are tests covering conflicts and duplicity).

Implementation ideas

No response

michalvavrik avatar Oct 10 '22 20:10 michalvavrik

/cc @geoand, @iocanel, @matejvasek, @patriot1burke

quarkus-bot[bot] avatar Oct 10 '22 20:10 quarkus-bot[bot]

I don't seem to find time to do this and there was no user requests so closing.

michalvavrik avatar Jul 21 '23 15:07 michalvavrik