quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

Kubernetes: Correct artifact path location

Open Sgitario opened this issue 3 years ago • 6 comments

Adding dependencies like quarkus-openshift and quarkus-kubernetes-config might lead to running the Kubernetes processor when the JAR file is not correct yet.

With these changes, we'll get always the correct artifact. Fix https://github.com/quarkusio/quarkus/issues/28108

Sgitario avatar Sep 21 '22 12:09 Sgitario

cc @iocanel @michalvavrik

I've tested these changes in JVM and native, but I'd appreciate if you have another round to ensure that it works the same for Native before merging @michalvavrik.

Sgitario avatar Sep 21 '22 12:09 Sgitario


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building d8245b1f61bdf0cffdb1e61186dd40bb4e8be3a6

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

:gear: Initial JDK 11 Build #

- Failing: integration-tests/kubernetes/quarkus-standard-way 

:package: integration-tests/kubernetes/quarkus-standard-way

Failed to execute goal net.revelc.code:impsort-maven-plugin:1.7.0:check (check-imports) on project quarkus-integration-test-kubernetes-standard: Imports are not sorted in /home/runner/work/quarkus/quarkus/integration-tests/kubernetes/quarkus-standard-way/src/test/java/io/quarkus/it/kubernetes/OpenshiftWithKubernetesConfigTest.java

quarkus-bot[bot] avatar Sep 21 '22 12:09 quarkus-bot[bot]


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building 238d5be8460b71ddc8f15faa78f962d0e281f24d

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
JVM Tests - JDK 17 MacOS M1 Build Failures Logs Raw logs
JVM Tests - JDK 18 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

:gear: JVM Tests - JDK 11 #

- Failing: integration-tests/kubernetes/quarkus-standard-way 

:package: integration-tests/kubernetes/quarkus-standard-way

io.quarkus.it.kubernetes.GeneratedKubernetesResourcesBuildItemTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.ChainBuildException: Cycle detected:
		   io.quarkus.deployment.pkg.steps.JarResultBuildStep#buildRunnerJar produced class io.quarkus.deployment.pkg.builditem.JarBuildItem

:gear: JVM Tests - JDK 11 Windows #

- Failing: integration-tests/kubernetes/quarkus-standard-way 

:package: integration-tests/kubernetes/quarkus-standard-way

io.quarkus.it.kubernetes.GeneratedKubernetesResourcesBuildItemTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.ChainBuildException: Cycle detected:
		   io.quarkus.kubernetes.deployment.KubernetesProcessor#build produced class io.quarkus.kubernetes.spi.GeneratedKubernetesResourceBuildItem

:gear: JVM Tests - JDK 17 #

- Failing: integration-tests/kubernetes/quarkus-standard-way 

:package: integration-tests/kubernetes/quarkus-standard-way

io.quarkus.it.kubernetes.GeneratedKubernetesResourcesBuildItemTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.ChainBuildException: Cycle detected:
		   io.quarkus.kubernetes.deployment.KubernetesProcessor#build produced class io.quarkus.kubernetes.spi.GeneratedKubernetesResourceBuildItem

:gear: JVM Tests - JDK 17 MacOS M1 #

- Failing: integration-tests/kubernetes/quarkus-standard-way 

:package: integration-tests/kubernetes/quarkus-standard-way

io.quarkus.it.kubernetes.GeneratedKubernetesResourcesBuildItemTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.ChainBuildException: Cycle detected:
		   io.quarkus.kubernetes.deployment.KubernetesProcessor#build produced class io.quarkus.kubernetes.spi.GeneratedKubernetesResourceBuildItem

:gear: JVM Tests - JDK 18 #

- Failing: integration-tests/kubernetes/quarkus-standard-way 

:package: integration-tests/kubernetes/quarkus-standard-way

io.quarkus.it.kubernetes.GeneratedKubernetesResourcesBuildItemTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.ChainBuildException: Cycle detected:
		   io.quarkus.deployment.pkg.steps.JarResultBuildStep#buildRunnerJar produced class io.quarkus.deployment.pkg.builditem.JarBuildItem

quarkus-bot[bot] avatar Sep 21 '22 14:09 quarkus-bot[bot]

Hello @Sgitario , unfortunately we are having cluster issues today, but I check once I can.

michalvavrik avatar Sep 21 '22 15:09 michalvavrik

Thank you for the fix btw.

michalvavrik avatar Sep 21 '22 15:09 michalvavrik

I run tests - reproducer in JVM and Quarkus QE TS in JVM/native are fixed. Reproduced failed in native mode, but it also failed when I run it with current main (exception looks not related).

michalvavrik avatar Sep 21 '22 18:09 michalvavrik

It seems that the current solution introduces build cycle issues: GeneratedResourceBuildItem -> JarBuildItem - > KubernetesProcessor... and again So, I will need to find another solution.

Sgitario avatar Sep 22 '22 05:09 Sgitario

Is this now ready to go @Sgitario ?

geoand avatar Sep 23 '22 06:09 geoand

Is this now ready to go @Sgitario ?

From my point of view, yes +1

Sgitario avatar Sep 23 '22 07:09 Sgitario