quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

Quarkus style enhancements: Security overview doc

Open michelle-purcell opened this issue 2 years ago • 4 comments

Ref #QDOCS-33

First iteration of edits to enhance the SECURITY ARCHITECTURE AND GUIDES guide and apply some of the recently agreed Quarkus style guidelines as described in the Quarkus contributor guide.

michelle-purcell avatar Sep 20 '22 18:09 michelle-purcell

@sberyozkin - I completed a first pass at editing the main overview page in the as-is structure. I have some questions about the content too. Thanks :-)

michelle-purcell avatar Sep 20 '22 18:09 michelle-purcell

@sheilamjones - Hey Sheila, thanks for flagging the overlap with PR #27176. I made a very minor tweak to the OIDC section that you already perfected, mainly to move the links into a table. What do you think? I can reverse if this breaks what you had agreed with SMEs. Thanks :-)

michelle-purcell avatar Sep 20 '22 18:09 michelle-purcell

Thanks for a quality PR, @michelle-purcell, I left a few minor suggestions but overall it all looks very good IMHO

sberyozkin avatar Sep 21 '22 12:09 sberyozkin

@sberyozkin - Thank you so much for your review and feedback. I have applied all of your suggestions and fixed the other comments.

michelle-purcell avatar Sep 21 '22 16:09 michelle-purcell

Thanks @michelle-purcell :-)

sberyozkin avatar Sep 22 '22 16:09 sberyozkin

@gsmet Hi Guillaume, not sure why the bot has added an agroal label, have a look please

sberyozkin avatar Sep 22 '22 16:09 sberyozkin