quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

Support "INHERIT" for quarkus.jib.jvm-entrypoint and quarkus.jib.native-entrypoint

Open Dieken opened this issue 2 years ago • 6 comments

jib-maven-plugin and jib-gradle-plugin both support this option to inherit entrypoint from base image, so make Quarkus learn it.

Resolves https://github.com/quarkusio/quarkus/issues/28071

Dieken avatar Sep 20 '22 15:09 Dieken

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

quarkus-bot[bot] avatar Sep 20 '22 15:09 quarkus-bot[bot]

Interesting!

Can you also update one of the integration tests to use this property so we can properly make test it?

geoand avatar Sep 20 '22 16:09 geoand

Interesting!

Can you also update one of the integration tests to use this property so we can properly make test it?

I added an integration test, ./mvnw -f integration-tests/container-image clean install passed but ./mvnw -f integration-tests/container-image clean install -Dnative failed, I can't tell whether the former really passed and why the latter failed, the log is too few and ambiguous.

Dieken avatar Sep 21 '22 10:09 Dieken

Did you try the tips mentioned here? Essentially you should use -Dstart-containers -Dtest-containers

geoand avatar Sep 21 '22 12:09 geoand

Did you try the tips mentioned here? Essentially you should use -Dstart-containers -Dtest-containers

You are right, these properties start the real tests.

These tests all passed, I didn't run all tests because it's too slow.

./mvnw clean install -f integration-tests/container-image/maven-invoker-way -Dinvoker.test=container-build-jib-appcds -Dstart-containers -Dtest-containers

./mvnw clean install -f integration-tests/container-image/maven-invoker-way -Dinvoker.test=container-build-jib-appcds -Dstart-containers -Dtest-containers -Dnative

./mvnw clean install -f integration-tests/container-image/maven-invoker-way -Dinvoker.test=container-build-jib-inherit -Dstart-containers -Dtest-containers

./mvnw clean install -f integration-tests/container-image/maven-invoker-way -Dinvoker.test=container-build-jib-inherit -Dstart-containers -Dtest-containers -Dnative

container-build-jib-inherit is modified from container-build-jib-appcds.

So I think everything should be ok :-)

Dieken avatar Sep 21 '22 13:09 Dieken

Looks good, thanks!

geoand avatar Sep 21 '22 14:09 geoand

https://github.com/quarkusio/quarkus/wiki/Release-Planning

2.14 will be released in Nov. , could you cherry-pick this commit into 2.13? This is a very small but useful enhancement for me :-)

@geoand

Dieken avatar Sep 22 '22 14:09 Dieken

Yeah, I support that would be fine.

geoand avatar Sep 22 '22 14:09 geoand

Quarkus 2.13.0 is released, could you backport this to 2.13.1? Thanks!

Dieken avatar Sep 29 '22 03:09 Dieken

That's the point of the label :)

geoand avatar Sep 29 '22 05:09 geoand