quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

Initial work to support multiple profiles

Open radcortez opened this issue 2 years ago • 3 comments

Initial work to support #27760.

Get rid of calls to ProfileManager#getActiveProfile and rely on the profiles list coming from SmallRye Config.

radcortez avatar Sep 20 '22 12:09 radcortez

/cc @Sanne, @gsmet, @yrodiere

quarkus-bot[bot] avatar Sep 20 '22 12:09 quarkus-bot[bot]

/cc @ia3andy

radcortez avatar Sep 20 '22 12:09 radcortez


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building 634476e06d4ce00a42cf21bcde9a837ff12082a9

Status Name Step Failures Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 11
:heavy_check_mark: JVM Tests - JDK 17
:heavy_check_mark: JVM Tests - JDK 17 MacOS M1
JVM Tests - JDK 18 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

:gear: JVM Tests - JDK 18 #

- Failing: extensions/keycloak-admin-client-reactive/deployment 
! Skipped: integration-tests/keycloak-authorization 

:package: extensions/keycloak-admin-client-reactive/deployment

io.quarkus.keycloak.admin.client.reactive.KeycloakAdminClientInjectionDevServicesTest.testGetRoles line 34 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <200> but was: <500>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

quarkus-bot[bot] avatar Sep 20 '22 17:09 quarkus-bot[bot]


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building db01fb55c17789170afd33adf052feb510599f68

Status Name Step Failures Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 11
:heavy_check_mark: JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner :warning: Check → Logs Raw logs
JVM Tests - JDK 18 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

:gear: JVM Tests - JDK 18 #

- Failing: extensions/smallrye-graphql/deployment 
! Skipped: extensions/smallrye-graphql-client/deployment integration-tests/hibernate-orm-graphql-panache integration-tests/smallrye-graphql and 1 more

:package: extensions/smallrye-graphql/deployment

io.quarkus.smallrye.graphql.deployment.ConcurrentAuthTest.concurrentAllFilmsOnly line 66 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: Unauthorized response codes were found ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

quarkus-bot[bot] avatar Sep 30 '22 20:09 quarkus-bot[bot]

What's the status of this?

Seems important to have :)

geoand avatar Oct 05 '22 07:10 geoand

I am waiting for the CI to pass to give it a try

ia3andy avatar Oct 05 '22 07:10 ia3andy

CI has passed 😉

geoand avatar Oct 05 '22 07:10 geoand

Would like some feedback from @ia3andy, since this was mainly to fix #27760.

radcortez avatar Oct 10 '22 12:10 radcortez

I've tried it with different cases and it seems to work fine (and as I expect it to work).

ia3andy avatar Oct 19 '22 13:10 ia3andy

Approve? :)

radcortez avatar Oct 19 '22 16:10 radcortez

As this PR is side-effect friendly, I think it would be wise to have another review.

@gastaldi maybe?

ia3andy avatar Oct 20 '22 08:10 ia3andy

I'm going to rebase this on main to get another CI run.

geoand avatar Oct 26 '22 07:10 geoand

I think we should get this in 2.14. @gsmet WDYT?

geoand avatar Oct 26 '22 07:10 geoand


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building 0184bc310304c416be6f08a9d1d05b9845fecfc3

Status Name Step Failures Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 17
:heavy_check_mark: JVM Tests - JDK 17 MacOS M1
:heavy_check_mark: JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

:gear: JVM Tests - JDK 11 Windows #

- Failing: extensions/opentelemetry/deployment 
! Skipped: integration-tests/micrometer-prometheus integration-tests/opentelemetry integration-tests/opentelemetry-grpc and 5 more

:package: extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.instrumentation.RestClientOpenTelemetryTest.urlWithoutAuthentication line 112 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <CLIENT> but was: <SERVER>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

quarkus-bot[bot] avatar Oct 26 '22 13:10 quarkus-bot[bot]

@gsmet up

ia3andy avatar Nov 21 '22 12:11 ia3andy


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building bc4036ad3d6114534d67ac5035d8cde045beb16f

Status Name Step Failures Logs Raw logs
:hourglass: JVM Tests - JDK 11 Build :warning: Check → Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 17
:heavy_check_mark: JVM Tests - JDK 17 MacOS M1
:heavy_check_mark: JVM Tests - JDK 18
Native Tests - Messaging1 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

:gear: Native Tests - Messaging1 #

- Failing: integration-tests/reactive-messaging-kafka 

:package: integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorIT.testPets - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Unable to successfully launch process '22066'. Exit code is: '1'.
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.throwBootFailureException(QuarkusIntegrationTestExtension.java:337)
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.beforeEach(QuarkusIntegrationTestExtension.java:110)

quarkus-bot[bot] avatar Nov 21 '22 17:11 quarkus-bot[bot]

Failing Jobs - Building 5cf686e7e5da947fbf8c6b362b2ba5d29ae52ea0

Status Name Step Failures Logs Raw logs
:heavy_check_mark: JVM Tests - JDK 11
:heavy_check_mark: JVM Tests - JDK 17
:heavy_check_mark: JVM Tests - JDK 17 MacOS M1
JVM Tests - JDK 18 Build Failures Logs Raw logs
:heavy_check_mark: Maven Tests - JDK 11
:hourglass: Maven Tests - JDK 11 Windows Build :warning: Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

:gear: JVM Tests - JDK 18 #

- Failing: integration-tests/reactive-messaging-hibernate-orm 

:package: integration-tests/reactive-messaging-hibernate-orm

io.quarkus.it.kafka.KafkaConnectorTest.testFruits line 50 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <1> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

quarkus-bot[bot] avatar Nov 22 '22 22:11 quarkus-bot[bot]

/ping @gsmet

radcortez avatar Nov 29 '22 12:11 radcortez

@radcortez I think with two approvals we can merge?

ia3andy avatar Nov 29 '22 14:11 ia3andy

This being a big change I think making it Quarkus 3.0 might be a good idea no?

ia3andy avatar Nov 29 '22 14:11 ia3andy

@radcortez I think with two approvals we can merge?

Sure, just wanted to make sure that @gsmet was ok with this.

This being a big change I think making it Quarkus 3.0 might be a good idea no?

Hum, I thought you needed this sooner. I mean, it is a considerable change, but not so big that it requires a major version.

radcortez avatar Nov 30 '22 10:11 radcortez

@radcortez, I think @gsmet had plenty of time to give an opinion on this :) I am not sure if the CI is considered as passed or not, but if it is, you can merge

ia3andy avatar Nov 30 '22 10:11 ia3andy

The CI failure is unrelated. A timeout issue.

Well, I'll be merging this then.

radcortez avatar Nov 30 '22 16:11 radcortez