quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

Upgrade to SmallRye GraphQL 1.7.0 (graphql-java 19.0)

Open phillip-kruger opened this issue 2 years ago • 2 comments

This PR upgrades to SmallRye GraphQL 1.7.0 that contains a new version of graphql-java (v19.0). The validation messages now supports i18n and the default message changed slightly (hence the overrides in the MicroProfile GraphQL TCK)

This PR also adds some new configuration options:

  • quarkus.smallrye-graphql.instrumentation-query-complexity
  • quarkus.smallrye-graphql.instrumentation-query-depth
  • quarkus.smallrye-graphql.parser-capture-ignored-chars
  • quarkus.smallrye-graphql.parser-capture-line-comments
  • quarkus.smallrye-graphql.parser-capture-source-location
  • quarkus.smallrye-graphql.parser-max-tokens
  • quarkus.smallrye-graphql.parser-max-whitespace-tokens

Signed-off-by: Phillip Kruger [email protected]

phillip-kruger avatar Aug 10 '22 00:08 phillip-kruger

That is why this is still a draft. Busy with the 2.0.0.RC release

phillip-kruger avatar Aug 10 '22 08:08 phillip-kruger


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building 2b87b5c253fc2d7d9c504c65bdac2166a402ed69

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs
:heavy_check_mark: Gradle Tests - JDK 11 Windows
Native Tests - Misc3 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

:gear: Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

:package: integration-tests/gradle

io.quarkus.gradle.devmode.AvroDevModeTest.main line 15 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.gradle.devmode.CompositeBuildWithDependenciesDevModeTest.main line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.gradle.devmode.DotEnvQuarkusDevModeConfigurationTest.main line 13 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

:gear: Native Tests - Misc3 #

- Failing: integration-tests/smallrye-graphql integration-tests/smallrye-graphql-client 

:package: integration-tests/smallrye-graphql

io.quarkus.it.smallrye.graphql.ApplicationPropertiesOverrideIT.testEndpoint line 32 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.smallrye.graphql.GraphQLAndFaultToleranceIT.testGraphQLAndFaultToleranceTogether - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.smallrye.graphql.GreetingResourceTestIT.testEndpoint - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.smallrye.graphql.GreetingsResourceTestIT.test - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

:package: integration-tests/smallrye-graphql-client

io.quarkus.it.smallrye.graphql.client.DynamicClientIT.testDynamicClientSingleResultOperationOverHttp - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <204> but was <500>.

io.quarkus.it.smallrye.graphql.client.DynamicClientIT.testDynamicClientSubscription - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

io.quarkus.it.smallrye.graphql.client.DynamicClientIT.testDynamicClientSingleResultOperationOverWebSocket - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

io.quarkus.it.smallrye.graphql.client.TypesafeClientIT.testTypesafeClientSingleResultOperationOverHttp - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <204> but was <500>.

io.quarkus.it.smallrye.graphql.client.TypesafeClientIT.testHeader - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <204> but was <500>.

io.quarkus.it.smallrye.graphql.client.TypesafeClientIT.testTypesafeClientSingleResultOperationOverWebSocket - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

io.quarkus.it.smallrye.graphql.client.TypesafeClientIT.testNonNull - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <204> but was <500>.

quarkus-bot[bot] avatar Aug 10 '22 14:08 quarkus-bot[bot]

Failures look related.

gsmet avatar Aug 10 '22 15:08 gsmet


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building 2b87b5c253fc2d7d9c504c65bdac2166a402ed69

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs
:heavy_check_mark: Gradle Tests - JDK 11 Windows
Native Tests - Misc3 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

:gear: Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

:package: integration-tests/gradle

io.quarkus.gradle.devmode.CompositeBuildWithDependenciesDevModeTest.main line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

:gear: Native Tests - Misc3 #

- Failing: integration-tests/smallrye-graphql integration-tests/smallrye-graphql-client 

:package: integration-tests/smallrye-graphql

io.quarkus.it.smallrye.graphql.ApplicationPropertiesOverrideIT.testEndpoint line 32 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.smallrye.graphql.GraphQLAndFaultToleranceIT.testGraphQLAndFaultToleranceTogether - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.smallrye.graphql.GreetingResourceTestIT.testEndpoint - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.smallrye.graphql.GreetingsResourceTestIT.test - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

:package: integration-tests/smallrye-graphql-client

io.quarkus.it.smallrye.graphql.client.DynamicClientIT.testDynamicClientSingleResultOperationOverHttp - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <204> but was <500>.

io.quarkus.it.smallrye.graphql.client.DynamicClientIT.testDynamicClientSubscription - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

io.quarkus.it.smallrye.graphql.client.DynamicClientIT.testDynamicClientSingleResultOperationOverWebSocket - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

io.quarkus.it.smallrye.graphql.client.TypesafeClientIT.testTypesafeClientSingleResultOperationOverHttp - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <204> but was <500>.

io.quarkus.it.smallrye.graphql.client.TypesafeClientIT.testHeader - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <204> but was <500>.

io.quarkus.it.smallrye.graphql.client.TypesafeClientIT.testTypesafeClientSingleResultOperationOverWebSocket - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

io.quarkus.it.smallrye.graphql.client.TypesafeClientIT.testNonNull - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <204> but was <500>.

quarkus-bot[bot] avatar Aug 11 '22 00:08 quarkus-bot[bot]

@gsmet Yes native failed due to new i18n resource from graphql-java. Fixed now. Should be ok, lets see what CI does now.

phillip-kruger avatar Aug 11 '22 08:08 phillip-kruger

Failing Jobs - Building 694caccf8fc9340f5980d37048264818a6511f71

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs
:heavy_check_mark: Gradle Tests - JDK 11 Windows

Full information is available in the Build summary check run.

Failures

:gear: Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

:package: integration-tests/gradle

io.quarkus.gradle.devmode.CompositeBuildWithDependenciesDevModeTest.main line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

quarkus-bot[bot] avatar Aug 11 '22 12:08 quarkus-bot[bot]

Thanks @gsmet !

phillip-kruger avatar Aug 11 '22 13:08 phillip-kruger