Override target port used when creating openshift route

[Dairdevil]

Addressing issue https://github.com/quarkusio/quarkus/issues/26587

WIP, wanted to check with @geoand and/or @iocanel if you're happy with this approach? This change should have broken one of the ITs which I will update and extend if you think I'm heading in the right direction with this

[geoand]

Thanks for this!

Seems reasonable to me, but I will leave it up to @iocanel to decide

[Dairdevil]

Updated the existing IT and added a new one to include covering the new config option

[quarkus-bot[bot]]

---

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

---

Failing Jobs - Building c00cf75643e4fe3d7b295f6a2adae72a5ef754b3

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	Build	Failures	Logs	Raw logs

Failures

:gear: Initial JDK 11 Build #

- Failing: extensions/kubernetes/vanilla/deployment 
! Skipped: docs extensions/kubernetes/kind/deployment extensions/kubernetes/minikube/deployment and 5 more

:package: extensions/kubernetes/vanilla/deployment

✖ Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.20.0:validate (default) on project quarkus-kubernetes-deployment: File '/home/runner/work/quarkus/quarkus/extensions/kubernetes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/OpenshiftProcessor.java' has not been previously formatted. Please format file (for example by invoking `mvn -f extensions/kubernetes/vanilla/deployment net.revelc.code.formatter:formatter-maven-plugin:2.20.0:format`) and commit before running validation!

[iocanel]

Also, I'd like to mention that this also needs to be adressed on dekorate (which is currently in progress), so in the future this will be redundant. Till then, I would glaldy accept this PR once the minor changes are addressed.

[Dairdevil]

Thanks for the review @iocanel, making changes now

[Dairdevil]

Thanks @gsmet just doing that now. I might be having the same issue as my other PR where the CI checks didn't trigger, am I doing something wrong?

[geoand]

You aren't doing anything wrong :).

It's just the default setting kicking on.

[Dairdevil]

Apologies, I have had an absolute nightmare with git here. Ended up doing a fresh branch from main and reapplying the changes so hopefully its all clean now, however the bot has been confused as a result of my messing about and applied a load of tags.

[geoand]

No problem at all! Thanks for persevering!

[quarkus-bot[bot]]

Failing Jobs - Building 7f30d02efb9b78b373f163bf5a03c45fc49bdf4c

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	Build	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	Build	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17	Build	Failures	Logs	Raw logs
✖	JVM Tests - JDK 18	Build	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

:gear: JVM Tests - JDK 11 #

- Failing: integration-tests/kubernetes/quarkus-standard-way 

:package: integration-tests/kubernetes/quarkus-standard-way

✖ io.quarkus.it.kubernetes.OpenshiftWithApplicationPropertiesTest.assertGeneratedResources line 82 - More details - Source on GitHub

org.assertj.core.error.AssertJMultipleFailuresError: 

[List check single element] (1 failure)

✖ io.quarkus.it.kubernetes.OpenshiftWithDeploymentWithoutSelectorsTest.assertGeneratedResources line 49 - More details - Source on GitHub

org.assertj.core.error.AssertJMultipleFailuresError: 

[List check single element] (1 failure)

✖ io.quarkus.it.kubernetes.OpenshiftWithRoutePropertiesCustomServicePortTest.assertGeneratedResources line 57 - More details - Source on GitHub

org.assertj.core.error.AssertJMultipleFailuresError: 

[List check single element] (1 failure)

---

:gear: JVM Tests - JDK 11 Windows #

- Failing: integration-tests/kubernetes/quarkus-standard-way 

:package: integration-tests/kubernetes/quarkus-standard-way

✖ io.quarkus.it.kubernetes.OpenshiftWithApplicationPropertiesTest.assertGeneratedResources line 82 - More details - Source on GitHub

org.assertj.core.error.AssertJMultipleFailuresError: 

[List check single element] (1 failure)

✖ io.quarkus.it.kubernetes.OpenshiftWithDeploymentWithoutSelectorsTest.assertGeneratedResources line 49 - More details - Source on GitHub

org.assertj.core.error.AssertJMultipleFailuresError: 

[List check single element] (1 failure)

✖ io.quarkus.it.kubernetes.OpenshiftWithRoutePropertiesCustomServicePortTest.assertGeneratedResources line 57 - More details - Source on GitHub

org.assertj.core.error.AssertJMultipleFailuresError: 

[List check single element] (1 failure)

---

:gear: JVM Tests - JDK 17 #

- Failing: integration-tests/kubernetes/quarkus-standard-way 

:package: integration-tests/kubernetes/quarkus-standard-way

✖ io.quarkus.it.kubernetes.OpenshiftWithApplicationPropertiesTest.assertGeneratedResources line 82 - More details - Source on GitHub

org.assertj.core.error.AssertJMultipleFailuresError: 

[List check single element] (1 failure)

✖ io.quarkus.it.kubernetes.OpenshiftWithDeploymentWithoutSelectorsTest.assertGeneratedResources line 49 - More details - Source on GitHub

org.assertj.core.error.AssertJMultipleFailuresError: 

[List check single element] (1 failure)

✖ io.quarkus.it.kubernetes.OpenshiftWithRoutePropertiesCustomServicePortTest.assertGeneratedResources line 57 - More details - Source on GitHub

org.assertj.core.error.AssertJMultipleFailuresError: 

[List check single element] (1 failure)

---

:gear: JVM Tests - JDK 18 #

- Failing: integration-tests/kubernetes/quarkus-standard-way 

:package: integration-tests/kubernetes/quarkus-standard-way

✖ io.quarkus.it.kubernetes.OpenshiftWithApplicationPropertiesTest.assertGeneratedResources line 82 - More details - Source on GitHub

org.assertj.core.error.AssertJMultipleFailuresError: 

[List check single element] (1 failure)

✖ io.quarkus.it.kubernetes.OpenshiftWithDeploymentWithoutSelectorsTest.assertGeneratedResources line 49 - More details - Source on GitHub

org.assertj.core.error.AssertJMultipleFailuresError: 

[List check single element] (1 failure)

✖ io.quarkus.it.kubernetes.OpenshiftWithRoutePropertiesCustomServicePortTest.assertGeneratedResources line 57 - More details - Source on GitHub

org.assertj.core.error.AssertJMultipleFailuresError: 

[List check single element] (1 failure)

[iocanel]

@Sgitario: AFAIR, you were working on this from the dekorate side. What is the current status? Is this still relevant?

[Sgitario]

@Sgitario: AFAIR, you were working on this from the dekorate side. What is the current status? Is this still relevant?

Indeed, this is already supported on dekorate side: https://github.com/dekorateio/dekorate/commit/ef3321e4fab7496175a17066fda75602cd6af3e4. However, there are some necessary changes on Quarkus side too. I will address this in a separated pull request. Thanks for the ping!

[Sgitario]

Closing this pull request as the changes became obsolete after bumping Dekorate to the latest version. The new pull request is https://github.com/quarkusio/quarkus/pull/29120.