quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

Published 20 hours ago • verified publisher icon quarkusio

Added "User-Agent" header to requests made to the Lambda Runtime API

Open msailes opened this issue 3 years ago • 6 comments

The value of the header will be in the format "quarkus/%s-%s" where the first position will be a description of the Java version and the second being the version of Quarkus.

There were no existing tests for the class I changed, I'd be happy to write some tests if given guidance.

Thanks,

msailes avatar Nov 15 '21 11:11 msailes

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with dot

This message is automatically generated by a bot.

quarkus-bot[bot] avatar Nov 15 '21 11:11 quarkus-bot[bot]

this feels like something we should have config for that the various http clients will be able to use?

maxandersen avatar Nov 15 '21 11:11 maxandersen

Hi @maxandersen,

Maybe, I couldn't see any http client in this module, so I followed the style which was existing.

msailes avatar Nov 15 '21 12:11 msailes

this feels like something we should have config for that the various http clients will be able to use?

I definitely agree

geoand avatar Nov 29 '21 09:11 geoand

I think having a configurable user agent for lambda would be a good first step. If we generalize it at some point we could use the more general one if not set.

@msailes I'm not sure we have some config root for lambda yet though. My guess would be to add something to LambdaConfig. If you're still interested in finalizing this, I suppose you could ask for @matejvasek 's help if you have questions.

gsmet avatar Jan 12 '22 15:01 gsmet

@gsmet @msailes I didn't work much on aws lambda directly, I only did some work wrt Funqy binding, AFAIK we don't configure user-agent there.

cc @patriot1burke

matejvasek avatar Apr 06 '22 20:04 matejvasek

Just curious, why the user agent? Does the lambda event server want that information?

patriot1burke avatar Sep 05 '22 19:09 patriot1burke

Yes, it helps us understand which frameworks are used.

msailes avatar Sep 05 '22 19:09 msailes

rebase, squash and i'll spin off CI. Sorry this fell through the cracks.

patriot1burke avatar Sep 05 '22 19:09 patriot1burke

No problem

msailes avatar Sep 06 '22 08:09 msailes

Updated

msailes avatar Sep 09 '22 14:09 msailes

Can you please rebase the PR onto main (instead of merging main into this PR)?

Thanks

geoand avatar Sep 12 '22 07:09 geoand

Done

msailes avatar Sep 12 '22 07:09 msailes

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

:no_entry_sign: This workflow run has been cancelled.

Failing Jobs - Building f73224bee8e8bfff99451d409ab42520ace997b4

Status Name Step Failures Logs Raw logs
:hourglass: Initial JDK 11 Build :warning: Check → Logs Raw logs
:hourglass: Attach pull request number :warning: Check → Logs Raw logs
:hourglass: CI Sanity Check :warning: Check → Logs Raw logs

quarkus-bot[bot] avatar Sep 12 '22 16:09 quarkus-bot[bot]