quarkus-quickstarts icon indicating copy to clipboard operation
quarkus-quickstarts copied to clipboard

add test { useJUnitPlatform } to getting-starting/build.gradle

Open vorburger opened this issue 6 years ago • 6 comments

vorburger avatar Apr 08 '19 20:04 vorburger

This (currently) doesn't actually work, Gradle test fails, see https://github.com/quarkusio/quarkus/issues/1930 for full discussion, and is thus WIP and created for easy reproducibility by others, and to find how we want to address this best.

vorburger avatar Apr 08 '19 20:04 vorburger

So we want that one but we can't merge it for now as it would break the build.

Please do not merge until quarkusio/quarkus#1930 is fixed!

gsmet avatar Apr 09 '19 09:04 gsmet

With the 2nd new commit, we could already merge this PR as-is now, and then improve later, see https://github.com/quarkusio/quarkus/issues/1930.

vorburger avatar Apr 09 '19 14:04 vorburger

I don't understand how we could merge that considering it's not working at the moment and the build fails?

The Gradle tests are now run as part of the release process so if it's failing, we can't release.

I'm +1 to have a pure Gradle getting started project but, clearly, we cannot merge this PR now.

gsmet avatar Apr 09 '19 17:04 gsmet

No, as I said, with the 2nd new commit (which adds exclude '**/*IT*'), the build does not fail anymore with this PR as it is now. It will run least the non-native Gradle test, which is progress and a step in the right direction (currently it runs no tests at all).

vorburger avatar Apr 09 '19 18:04 vorburger

Hello @gsmet I'm doing a year end clean up of my personal https://github.com/pulls and wanted to ask if you would still consider merging this very old Pull Request, or if we should forget about and close this? (This is a bulk message I'm posting to many issues to gauge what is still revelant.)

vorburger avatar Dec 04 '21 10:12 vorburger