gizmo icon indicating copy to clipboard operation
gizmo copied to clipboard

feat[class-creator]: Add loan pattern to incapsulate life cycle of ClassCreator inside API

Open poldinik opened this issue 10 months ago • 3 comments

#181

poldinik avatar Mar 30 '24 11:03 poldinik

I like the idea of this change (note that a few of the APIs I have added to this project in the past also use this pattern, and the new JDK classfile API does as well). But IMO we should apply it more uniformly, as opposed to haphazardly applying it to different places with no real overall plan.

dmlloyd avatar Apr 02 '24 16:04 dmlloyd

I like the idea of this change (note that a few of the APIs I have added to this project in the past also use this pattern, and the new JDK classfile API does as well). But IMO we should apply it more uniformly, as opposed to haphazardly applying it to different places with no real overall plan.

How we can lead ahead this feature more systematically? Which step you see I need to follow to propose it and contribute? I mean something like roadmap o design specification before actual develop and avoid waste of time if stakeholders don't like implementation

poldinik avatar Apr 06 '24 16:04 poldinik

This is a good question that I do not have an answer to. Maybe start with a high-level proposal that encompasses the existing API usages for method, class, and block creators, and go from there?

dmlloyd avatar Apr 22 '24 13:04 dmlloyd