quarkus-operator-sdk icon indicating copy to clipboard operation
quarkus-operator-sdk copied to clipboard

feat: Quarkus codestart support

Open metacosm opened this issue 2 years ago • 5 comments

  • feat: add initial support for codestart
  • refactor: move IT tests in the core module where they should be
  • chore: remove unused classes
  • feat: add initial code for generation
  • chore(tests): add codestart test

metacosm avatar Jun 01 '22 14:06 metacosm

Looks good so far, except i saw a snapshot version for the codestart in the test. Something will have to be done about that, I suppose.

aloubyansky avatar Jun 01 '22 14:06 aloubyansky

Looks good so far, except i saw a snapshot version for the codestart in the test. Something will have to be done about that, I suppose.

That's actually a pain… without specifying the version, this doesn't work. Ideally, we wouldn't need to specify the version and the codestart would automatically use the same version as the project.

metacosm avatar Jun 01 '22 14:06 metacosm

To workaround it, in the meantime, you could pass a system property containing the project version from the surefire/failsafe config.

aloubyansky avatar Jun 01 '22 14:06 aloubyansky

For example https://github.com/quarkusio/quarkus/blob/main/build-parent/pom.xml#L412-L414

aloubyansky avatar Jun 01 '22 14:06 aloubyansky

This is already done but it will need to wait for 1.10: https://github.com/quarkusio/quarkus/pull/25397

Until then: https://github.com/quarkiverse/quarkus-quinoa/blob/main/integration-tests/pom.xml#L55 and https://github.com/quarkiverse/quarkus-quinoa/blob/main/integration-tests/src/test/java/io/quarkiverse/quinoa/it/QuinoaCodestartIT.java#L17

ia3andy avatar Jun 02 '22 04:06 ia3andy