quarkus-micrometer-registry icon indicating copy to clipboard operation
quarkus-micrometer-registry copied to clipboard

Feature Request - Default value for OTEL_SERVICE_NAME

Open amoscatelli opened this issue 1 year ago • 3 comments

When using otel registry, OTEL_SERVICE_NAME should fall back to application name, if not provided in any other means.

If I don't specify OTEL_SERVICE_NAME I see this in NewRelic :

image

Instead I think this should behave like described in opentelemetry quarkus integration : https://quarkus.io/guides/opentelemetry

image

What do you think ?

amoscatelli avatar May 10 '23 17:05 amoscatelli

Here : https://github.com/quarkiverse/quarkus-micrometer-registry/blob/53fa22d5090846fa888740faeeaf124ea8b000a5/micrometer-registry-otlp/runtime/src/main/java/io/quarkiverse/micrometer/registry/otlp/OtlpConfig.java#L73

But if OTEL_SERVICE_NAME is not set, it should fall back to ${quarkus.application.name}

amoscatelli avatar May 10 '23 17:05 amoscatelli

@ebullient if you agree I can make a PR about this ...

Let me know Thank you

amoscatelli avatar May 10 '23 17:05 amoscatelli

PRs are always welcome. ;)

ebullient avatar May 10 '23 19:05 ebullient