quarkus-logging-json icon indicating copy to clipboard operation
quarkus-logging-json copied to clipboard

Add the new configuration property[enabledJavaTimeModule]

Open iqnev opened this issue 1 year ago • 3 comments

iqnev avatar Jul 18 '24 12:07 iqnev

Hi @SlyngDK I have provided a potential fix for this issue https://github.com/quarkiverse/quarkus-logging-json/issues/169

Could you please review it and provide your feedback?

iqnev avatar Jul 19 '24 12:07 iqnev

@iqnev I don't like the hard coded register approach. But I can accept some sort of configuration, for which jackson modules to register.

And the issue with modules is not auto registered is only an issue with native? Is there an other way to provide/detect the modules in native build?

SlyngDK avatar Jul 20 '24 13:07 SlyngDK

@iqnev I don't like the hard coded register approach. But I can accept some sort of configuration, for which jackson modules to register.

And the issue with modules is not auto registered is only an issue with native? Is there an other way to provide/detect the modules in native build?

@SlyngDK Actually, the current PR offers a fully configurable approach. The issue arises specifically with native mode. I had a brief conversation with @geoand , who mentioned that providing a default bean with JavaTimeModule() within the quarkus-logging-json extension could lead to a conflict with the quarkus-jackson extension

iqnev avatar Jul 21 '24 10:07 iqnev

Could it be an option to implement same behaviour as in the quarkus-jackson extension which is to autoregister modules like JavaTimeModule depending on if they are found on the classpath? See https://github.com/quarkusio/quarkus/blob/3.23/extensions/jackson/deployment/src/main/java/io/quarkus/jackson/deployment/JacksonProcessor.java#L358

ls-bit avatar Jun 04 '25 15:06 ls-bit