quarkus-logging-json icon indicating copy to clipboard operation
quarkus-logging-json copied to clipboard

Issue-143: Implement Pretty Printing

Open manstis opened this issue 3 years ago • 3 comments

See https://github.com/quarkiverse/quarkus-logging-json/issues/143

manstis avatar Apr 19 '22 12:04 manstis

Hi @SlyngDK IDK could you please approve running of the workflows?

This would make use of your extension easier in development environments where a formatted log output is handy.

Thank-you.

manstis avatar May 11 '22 05:05 manstis

Hi @SlyngDK is this PR of any interest?

manstis avatar Sep 12 '22 15:09 manstis

Hi @SlyngDK is this PR of any interest?

manstis avatar Oct 24 '22 15:10 manstis

@gastaldi @gsmet IDK if this PR is of any interest?

I don't get much (erm, any) reply from @SlyngDK but I see you've both been involved with this repository over time

(and you're RH!)

manstis avatar Jan 05 '23 11:01 manstis

I remember i tested, but was not formatted pretty as expected, maybe only one of the formatters. Also the testing not check the pretty formatting is done.

SlyngDK avatar Jan 05 '23 13:01 SlyngDK

Hi @SlyngDK

not formatted pretty as expected

"pretty print" is only supported for JSON

the testing not check the pretty formatting is done

The tests do check the if "pretty formatting" is done. See the change here.

See PrettyPrintingJsonProviderJsonbTest and PrettyPrintingJsonProviderJacksonTest.

manstis avatar Jan 05 '23 14:01 manstis

As an example.

Test (the most complex in the suite) assertEquals(format("{\"key\":{\"field1\":\"field1\",\"field2\":2389472389}}"), run("key", new TestPojo()));

KeyValueStructuredArgumentJsonbTest.testKeyValues() returns:

{"key":{"field1":"field1","field2":2389472389}}

PrettyPrintingJsonProviderJsonbTest.testKeyValues() returns:

{
    "key": {
        "field1": "field1",
        "field2": 2389472389
    }
}

manstis avatar Jan 05 '23 14:01 manstis

Closing.

It seems this will never be merged.

manstis avatar Jul 27 '23 11:07 manstis