quarkus-logging-json
quarkus-logging-json copied to clipboard
Issue-143: Implement Pretty Printing
See https://github.com/quarkiverse/quarkus-logging-json/issues/143
Hi @SlyngDK IDK could you please approve running of the workflows?
This would make use of your extension easier in development environments where a formatted log output is handy.
Thank-you.
Hi @SlyngDK is this PR of any interest?
Hi @SlyngDK is this PR of any interest?
@gastaldi @gsmet IDK if this PR is of any interest?
I don't get much (erm, any) reply from @SlyngDK but I see you've both been involved with this repository over time
(and you're RH!)
I remember i tested, but was not formatted pretty as expected, maybe only one of the formatters. Also the testing not check the pretty formatting is done.
Hi @SlyngDK
not formatted pretty as expected
"pretty print" is only supported for JSON
the testing not check the pretty formatting is done
The tests do check the if "pretty formatting" is done. See the change here.
See PrettyPrintingJsonProviderJsonbTest and PrettyPrintingJsonProviderJacksonTest.
As an example.
Test (the most complex in the suite)
assertEquals(format("{\"key\":{\"field1\":\"field1\",\"field2\":2389472389}}"), run("key", new TestPojo()));
KeyValueStructuredArgumentJsonbTest.testKeyValues() returns:
{"key":{"field1":"field1","field2":2389472389}}
PrettyPrintingJsonProviderJsonbTest.testKeyValues() returns:
{
"key": {
"field1": "field1",
"field2": 2389472389
}
}
Closing.
It seems this will never be merged.