quarkus-google-cloud-services icon indicating copy to clipboard operation
quarkus-google-cloud-services copied to clipboard

Adding GCP operations logging exception

Open Fungrim opened this issue 3 years ago • 3 comments

I created a fork and played around with adding support for logging directly to GCP operations. It's in a working proof of concept stage at the moment, and I though I should ask you guys if you think it is a good idea before I add more features and start polishing: https://github.com/Fungrim/quarkus-google-cloud-services/tree/main/logging

The ideas is:

  • Log directly to GCP using the Google Java library
  • Support both structured and unstructured logging
  • The log record instant and level should be first class citizen regardless
  • Support labels for things like POD name, app name etc (GCP logging labels acts as "dimensions" when analyzing logs)
  • Support trace ID as a first class citizen (to be able to link GCP traces with logs)
  • Default to ECS format, but make it customizable

The current status is: it works, has an integration test that needs a GCP project and thus isn't in main, and a rough, untested version of the ECS format is in. Has a list of todo's, mostly round configuration. Need more unit tests and polishing.

What do you think? Would you like this to end up as a pull request?

Fungrim avatar Dec 31 '21 08:12 Fungrim

Hi, please open a PR so we can discuss this. The integration test can be in the main integration test so I can run it manually. Add a REST resource class with exposes the multiple way to log but don't add any test classes if it could not be run from the CI.

loicmathieu avatar Jan 02 '22 15:01 loicmathieu

@loicmathieu Done: #225

Fungrim avatar Jan 03 '22 09:01 Fungrim

Let's keep it openned untill the PR is accepted ;)

loicmathieu avatar Jan 03 '22 09:01 loicmathieu

Fixed by #386

loicmathieu avatar Feb 15 '23 14:02 loicmathieu