quarkus-github-action icon indicating copy to clipboard operation
quarkus-github-action copied to clipboard

GHRepository Can Be Injected into an Action Method

Open gcw-it opened this issue 1 year ago • 4 comments

Fixes #302

  • See title
  • Resolved access to deprecated apis in GitHubActionProcessor.java. The sole remaining deprecation warning will sort itself out, when the deprecated api is removed.
  • The integration test will execute the real action, when running on GitHub. Locally the repository can't be injected due to the missing environment.
  • Documentation will follow

gcw-it avatar Aug 20 '24 15:08 gcw-it

@gsmet Are there any capabilities of the GHRepository class you'd like to highlight for the documentation?

gcw-it avatar Aug 20 '24 16:08 gcw-it

@gcw-it no, I think it's just about making it clear you can easily inject a properly set up GHRepository.

gsmet avatar Aug 20 '24 16:08 gsmet

Yes, the tests were pretty straight forward, until they weren't :-)

  • resolved comments
  • added documentation

gcw-it avatar Aug 20 '24 18:08 gcw-it

formatting error corrected

gcw-it avatar Aug 21 '24 16:08 gcw-it

@gsmet You're welcome

gcw-it avatar Aug 23 '24 13:08 gcw-it