darts icon indicating copy to clipboard operation
darts copied to clipboard

Concatenation of nodes in cell

Open tkanvar opened this issue 5 years ago • 0 comments

Hi,

Genotype concatenation calculation and printing has some bug.

Printing

During printing of genotype in search process, the main function calls genotype function, which is member function of class Network. There is a line in genotype function, "concat = range(2+self._steps-self._multiplier, self._steps+2)". This line produces [2,4] and not [2,3,4], which should have been the case. So the line should be replaced with something like concat = [] for i in range(2+self._steps-self._multiplier, self._steps+2): concat.append(i)

Calculation

According to the paper, only the feature maps of those nodes, whose outputs are not used as inputs to any other nodes in the cell, are concatenated to form the output of the cell. But according to the code in genotype function in Network class, it seems the code is blindly concatenating all internal nodes of the cell. So, according to me there should be a logic to check if top 2 most probable operations doesnt have a node in any of the nodes of the cell, then include the node in concatenation.

Does the above claims make sense?

tkanvar avatar Dec 29 '19 19:12 tkanvar