pyNetLogo icon indicating copy to clipboard operation
pyNetLogo copied to clipboard

Setup dependencies of pynetlogo on install_requires

Open j3mdamas opened this issue 3 years ago • 4 comments

Hi, Is there a particular reason for not stating the dependencies (pandas, numpy, scipy, JPype1) on the install_requires of the setup command? This would make the installation much smoother. I can make a PR, if you want, but I am not sure if there are particular versions of the dependencies that would be more suitable.

j3mdamas avatar Jun 15 '21 10:06 j3mdamas

it is very deliberate because in my experience using setup.py with explicit dependencies can easily break a python environment. I have had this happen to me too often over the last several years.

quaquel avatar Jun 15 '21 10:06 quaquel

Thanks for the very quick answer. I haven't faced that, but that's probably because I mostly create virtual environments from scratch. Maybe a requirements.txt file would be a nice to have instead, so that the person can just run pip install -r requirements.txt.

j3mdamas avatar Jun 15 '21 11:06 j3mdamas

might indeed be a good idea and should be quite easy to add.

quaquel avatar Jun 16 '21 19:06 quaquel

The simplest is:

JPype1
numpy
pandas
scipy

but something more controlled could be:

JPype1>=1.3,<1.4
numpy>=1.20,<1.21
pandas>=1.2,<1.3
scipy>=1.6,<1.7

j3mdamas avatar Jun 17 '21 08:06 j3mdamas

closed with https://github.com/quaquel/pyNetLogo/commit/0ab7e00fd126a40ce3c6d907b11fa3523521eac1

quaquel avatar Mar 09 '23 09:03 quaquel