Jan Kwakkel
Jan Kwakkel
the current `test_examples` in `mesa.tests` is currently explicitly skipped. I'll rewrite the tests given the new structure and make them work again hopefully somewhere this weekend.
I am testing locally against my branch for #2286, but I'll update the the yml in this branch to show CI here as well.
The smart thing to do would be to change the imports to `experimental.cell_space`. This would make this pr compatible with main.
> If you need anything on this PR let me know! How to get the build to succeed? It now errors out on reaction? Other than that, I think this...
> I really like how clean the API is looking, and how easy old components are replaced. Good stuff! I am also pleasantly surprised by (1) how easy the switch...
> Curious, did you encounter any limitations or go any ideas to do things more elegantly in the cell space? I have made various PRs related to grid spaces while...
I have updated Schelling after #222. @EwoutH any further comments or can this be approved?
> Could you split of the changes in the "basic" (as in https://github.com/projectmesa/mesa/pull/2349#issuecomment-2408945055) examples into a new, separate branch and save that somewhere where you can find it back in...
> For a proper port of the git history its way easier if we can move the examples at once, otherwise we're merging multiple related git histories which makes it...
Thanks for these comments. I just like to point out that most of these are comments on the original code from which I started, not the changes made in this...