EMAworkbench icon indicating copy to clipboard operation
EMAworkbench copied to clipboard

Published 20 hours ago • verified publisher icon quaquel

Drop Python 3.9 support, require 3.10+

Open EwoutH opened this issue 11 months ago • 5 comments

Following SPEC 0 Python 3.9 support is dropped for future minor and major releases, and will require Python 3.10+ from version 3.0 onwards.

The main benefit of requiring Python 3.10 is that we can implement type hinting more elegant in the workbench.

The 2.5.x branch will keep supporting Python 3.9.

EwoutH avatar Mar 27 '24 19:03 EwoutH

Coverage Status

coverage: 80.3%. remained the same when pulling b0ecdb93a493c500663bae00409e04c8b80d29d6 on python-3.10 into 10429e464ebb71611ec1b0486a4cf5926057e6fc on master.

coveralls avatar Mar 27 '24 19:03 coveralls

looks fine to me. Just one quick question (which I can look up myself once I have time). What is the default python version on DelftBlue?

quaquel avatar Mar 28 '24 08:03 quaquel

Default 3.9, with 3.10 pre-installed. I think it will be updated around summer again.

EwoutH avatar Mar 28 '24 08:03 EwoutH

We can backport all MPI changes to the 2.5 branch to maintain full compatibility.

EwoutH avatar Mar 28 '24 08:03 EwoutH

Ok, let me try and finish the mpi bugfix branch first (testing atm), so I don't need to worry about 3.9/3.10.

quaquel avatar Mar 28 '24 08:03 quaquel

Can we merge this one?

EwoutH avatar May 24 '24 13:05 EwoutH

I was wondering the same thing, but yes LGTM.

quaquel avatar May 24 '24 13:05 quaquel