unitary icon indicating copy to clipboard operation
unitary copied to clipboard
verified publisher icon quantumlib

dev_tools/pylint fails with pylint-3 and later

Open pavoljuhas opened this issue 1 year ago • 3 comments

The pylint execution fails on loading the custom 'pylint_copyright_checker' plugin. Related to https://github.com/quantumlib/Cirq/issues/6351

pavoljuhas avatar Oct 03 '24 21:10 pavoljuhas

There is no pylint_copyright_checker.py file in this repository, but there is also no wrong-or-nonexistent-copyright-notice check enabled in dev_tools/.pylintrc.

pylint-3 seems to error on plugins that do not exists, whereas pylint-2 silently ignored them. It also discovers a plenty of lint issues that were not reported before (perhaps missing --recursive=yes).

This should be re-scoped to syncing with cirq pylint settings.

pavoljuhas avatar Oct 04 '24 01:10 pavoljuhas

@dstrain115 - please reopen, there are open TODO items in dev_tools/.pylintrc for rules that need to be fixed and enabled.

pavoljuhas avatar Oct 07 '24 18:10 pavoljuhas

@solodov If you want to help with these, we need to enable the pylint tests one-by-one and fix the resulting pylint errors.

dstrain115 avatar Oct 15 '24 20:10 dstrain115