quantumlib
Change type comparisons to use numbers package.
Is your feature request related to a use case or problem?
In a comment on PR #430, @pavoljuhas suggested changing a certain type comparison to use numbers.Real. This seems like a good idea, and I would extend it further to say we should check other places in the code where similar changes should be made. This issue is to track the work on this goal.
What solution or approach do you envision?
No response
How urgent is this for you?
None
Hi @mhucka
Can I pick this issue?
I see that we need to change to number.Real for np.float32 values based on comment i PR #430 by Pavol. Should it be changed only for recirq/fermi_hubbard/parameters.py?
I see that we need to change to number.Real for np.float32 values based on comment i PR #430 by Pavol. Should it be changed only for recirq/fermi_hubbard/parameters.py?
We haven't looked at it closely, but I think it's unlikely to be required only in parameters.py. It would require going through the code more broadly.
Hi @mhucka
Rasied a PR with details about the changes. Could you please review and let me know.
https://github.com/quantumlib/ReCirq/pull/445