ReCirq icon indicating copy to clipboard operation
ReCirq copied to clipboard

fermi_hubbard publication_test is not hermetic

Open weinstein opened this issue 3 years ago • 1 comments

it downloads datasets from https://datadryad.org/stash/dataset/doi:10.5061/dryad.crjdfn32v the download URLs are not super stable, but also datadryad.org website unavailability can cause the recirq test suites to flake out and fail

It may be better to avoid the external dependency on datadryad.org in tests and mock out the download.

weinstein avatar Apr 26 '21 18:04 weinstein

Documenting discussion with the helpful folks at Dryad:

Our team has confirmed that individual files do not have their own unique link. Previously, the did but that was changed with the relaunch in 2019.

So a permanent fix should use the DOI of the dataset instead of URLs for individual files.

rmlarose avatar May 05 '21 02:05 rmlarose