Qualtran

Qualtran copied to clipboard

Make `And` a leaf bloq

2

Specific changes that are needed to do this part of #873 : - Any unit test that relies on the "sigma" return value of `call_graph` will change. This is brittle...

mpharrigan

Dead links in the docs

1

``` /usr/local/google/home/mpharrigan/qualtran/qualtran/docs/bloqs/chemistry/hubbard_model/qubitization/hubbard_model.ipynb:10027: WARNING: 'myst' cross-reference target not found: './qubitization_walk_operator.ipynb' [myst.xref_missing] /usr/local/google/home/mpharrigan/qualtran/qualtran/docs/bloqs/chemistry/resource_estimation.ipynb:20015: WARNING: 'myst' cross-reference target not found: '../state_preparation.ipynb' [myst.xref_missing] /usr/local/google/home/mpharrigan/qualtran/qualtran/docs/bloqs/chemistry/resource_estimation.ipynb:20015: WARNING: 'myst' cross-reference target not found: '../select_swap_qrom.py' [myst.xref_missing] /usr/local/google/home/mpharrigan/qualtran/qualtran/docs/bloqs/chemistry/resource_estimation.ipynb:30004: WARNING:...

mpharrigan

QROAMClean musical score diagram can fail to render

2

Taking the prep_thc bloq from [resource_estimation.ipynb](https://github.com/quantumlib/Qualtran/blob/main/qualtran/bloqs/chemistry/resource_estimation.ipynb) results in: ``` --------------------------------------------------------------------------- KeyError Traceback (most recent call last) File ~/projects/qualtran/qualtran/drawing/musical_score.py:226, in _update_assign_from_vals(regs, binst, vals, soq_assign, seq_x, topo_gen, manager) 225 try: --> 226...

fdmalone

In qualtran, we have "protocols" for annotating, deriving, and querying properties of bloqs. Practically, a protocol consists of - (a name) - A method on `Bloq` that takes no arguments...

mpharrigan

Capture the design and discussion around the proto-based serialization into a notebook that we can include in the docs

mpharrigan

mypy insufficiently strict?

2

#1345 fixed a bug with PrepareIdentity being constructed with a tuple of QDTypes when it expects a Tuple of Registers. It's surprising mypy didn't catch this. The issue is to...

fdmalone

big_O is buggy

1

big_O only takes into account all variables in the input expression (setting their limit to inf), but not once multiplied later. ```py import sympy from qualtran.resource_counting import big_O n =...

anurudhp

More generally the register size determination sort of assumes none of the registers are sided. The issue is to update or raise an error in attrs_post_init

fdmalone

Migrate t_complexity to `QECGatesCost` cost key

1

With the goal of #539 there are now two built-in ways of counting gates: one where you have to provide which gates to count and another, more-opinionated one that makes...

mpharrigan

qubitization_qpe_sparse_chem does not decompose

1

The bloq example "qubitization_qpe_sparse_chem" does not decompose all the way down. Minimal example is ```python bloq.as_composite_bloq().flatten() ``` ``` ValueError Traceback (most recent call last) File ~/qutran/qutran/qualtran/cirq_interop/_cirq_to_bloq.py:594, in decompose_from_cirq_style_method(bloq, method_name) 593...

mpharrigan