Qualtran icon indicating copy to clipboard operation
Qualtran copied to clipboard

Alternative rotation compilations/costs

Open fdmalone opened this issue 1 year ago • 2 comments

Currently our T costs derive from https://arxiv.org/pdf/1404.5320.pdf, which gives a mean cost of 1.149 log2 (1/ε) + 9.2 for a target precision of ε.

Many papers use a phase gradient gate instead for rotations (appendix A of https://doi.org/10.1103/PRXQuantum.1.020312) which requires b_r - 2 Toffolis for b_r bits of precision (it uses the first method to prepare a phase gradient register first and then adds into this). This is often significantly cheaper.

Need to think about rotations.

fdmalone avatar Sep 26 '23 21:09 fdmalone

cc @NoureldinYosri who has been thinking about this

mpharrigan avatar Sep 29 '23 18:09 mpharrigan

we currenly have a unified approach to the vanilla rotation models RotationLogarithmicModel and for constant cost models ConstantWithOverheadRotationCost both of which implement the same interface of RotationCostModel

Do we need to do more for this?

NoureldinYosri avatar Feb 28 '24 00:02 NoureldinYosri

Related: #1250

mpharrigan avatar Aug 08 '24 15:08 mpharrigan

Going to close this in favor of #1250 or open new issues to track specific asks

mpharrigan avatar Sep 03 '24 20:09 mpharrigan