Qualtran icon indicating copy to clipboard operation
Qualtran copied to clipboard

Multi-Control Pauli Decomposition is probably incorrect

Open tanujkhattar opened this issue 2 years ago • 2 comments

Right now, we don't have a test for correctness and as part of writing a gate locally, I discovered that the gate is probably not doing what it's promised to do (I tested for cirq.Z(q).controlled_by(*control_qubits, control_vals = [0] * len(control_qubits)))

This issue is to verify the correctness and add a validation test:

https://github.com/quantumlib/cirq-qubitization/blob/a2f283e0269d92d89aba2ce19e5b973019db5aca/cirq_qubitization/cirq_algos/multi_control_multi_target_pauli.py#L44

tanujkhattar avatar May 26 '23 17:05 tanujkhattar

@tanujkhattar I hit this recently and remembered I was supposed to look into it. Any idea what's going on before I dig in?

fdmalone avatar Aug 22 '23 19:08 fdmalone

@tanujkhattar did you fix this?

mpharrigan avatar May 01 '24 18:05 mpharrigan

#790 added tensor tests to verify the action, closing.

anurudhp avatar Jul 30 '24 06:07 anurudhp