Qualtran icon indicating copy to clipboard operation
Qualtran copied to clipboard

Add RSA Phase Estimate Bloq and Move ModExp to rsa/ subdirectory

Open fpapa250 opened this issue 1 year ago • 1 comments

I made a higher level top bloq with the phase estimation for shors for RSA. I also moved the bloqs to an rsa/ directory and moved the MeasureQFT shim to the factoring/ directory. Last, I made the ModExp bloq take an (n_exponent,) shaped QBit() register because the controls are used in the plus state in the phase estimation circuit so it can't be of type QUint (I think).

fpapa250 avatar Sep 29 '24 22:09 fpapa250

I think we discussed offline, but +1 to the top-level bloq. This should be set up as "phase estimation of the modular multiply operation". -1 to the signature change of ModExp, but maybe we don't include modexp as part of the decomposition if we frame the overall algorithm as phase estimation of modmul

mpharrigan avatar Oct 07 '24 23:10 mpharrigan