Qualtran icon indicating copy to clipboard operation
Qualtran copied to clipboard

Controlled Hamiltonian simulation not explicitly implemented

Open ejbobrow opened this issue 5 months ago • 3 comments

This is more of a feature request, but it looks like HamiltonianSimulationByGQSP doesn't have its own explicit control and uses the defaults for .controlled(). This gives errors like DecomposeTypeError: Could not build call graph for C[Toffoli]: Toffoli is atomic when trying to do resource counting with .t_complexity() or get_cost_value().

Maybe this could be extended by allowing for additional control in QubitizationWalkOperator with ControlledViaAnd and controlling the rotations in GeneralizedQSP.

ejbobrow avatar Sep 19 '24 20:09 ejbobrow