OpenFermion icon indicating copy to clipboard operation
OpenFermion copied to clipboard

Create pauli_term_grouping_test.py

Open hofong428 opened this issue 5 months ago • 5 comments

hofong428 avatar Jul 29 '25 18:07 hofong428

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jul 29 '25 18:07 google-cla[bot]

@hofong428 thank you for this work.

Please add a description to this pull request.

Also, this appears to be related to your PR #1100. If that's the case, please combine the two PRs (perhaps by moving this test file to the PR) because new code contributions should have test cases anyway, and thus the files belong together.

mhucka avatar Aug 01 '25 23:08 mhucka

So.. what should I do now?

On Sat, Aug 2, 2025 at 7:01 AM Michael Hucka @.***> wrote:

mhucka left a comment (quantumlib/OpenFermion#1101) https://github.com/quantumlib/OpenFermion/pull/1101#issuecomment-3145956902

@hofong428 https://github.com/hofong428 thank you for this work. There are some failures in the CI checks, as you can see. Also, the CodeQL scanner flagged some unused Python imports that can be removed from the files.

— Reply to this email directly, view it on GitHub https://github.com/quantumlib/OpenFermion/pull/1101#issuecomment-3145956902, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ34Y4MKMSBMRKCUJX4IGPL3LPWTBAVCNFSM6AAAAACCUWIII2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNBVHE2TMOJQGI . You are receiving this because you were mentioned.Message ID: @.***>

hofong428 avatar Aug 02 '25 20:08 hofong428

So.. what should I do now?

If this PR contains test cases for the contribution in PR #1100, then please add the file from this PR to PR #1100, close this PR, and continue at #1100.

The problems flagged by the CI here will still need to be addressed. It is up to your preferences whether you want to address them first and then move the file to the other PR, or move the file first and then address the problems. (When you push another commit to PR #1100 to add the file, it will trigger the CI jobs to run again, and the same errors will occur there until they are addressed.)

I hope I answered the question you were asking. If I misunderstood, please let me know.

mhucka avatar Aug 03 '25 03:08 mhucka

Crystal clear. Thanks for your help. I will re-submit later.

On Sun, Aug 3, 2025 at 11:08 AM Michael Hucka @.***> wrote:

mhucka left a comment (quantumlib/OpenFermion#1101) https://github.com/quantumlib/OpenFermion/pull/1101#issuecomment-3146940050

So.. what should I do now?

If this PR contains test cases for the contribution in PR #1100 https://github.com/quantumlib/OpenFermion/pull/1100, then please add the file from this PR to PR #1100 https://github.com/quantumlib/OpenFermion/pull/1100, close this PR, and continue at #1100 https://github.com/quantumlib/OpenFermion/pull/1100.

The problems flagged by the CI here will still need to be addressed. It is up to your preferences whether you want to address them first and then move the file to the other PR, or move the file first and then address the problems. (When you push another commit to PR #1100 https://github.com/quantumlib/OpenFermion/pull/1100 to add the file, it will trigger the CI jobs to run again, and the same errors will occur there until they are addressed.)

I hope I answered the question you were asking. If I misunderstood, please let me know.

— Reply to this email directly, view it on GitHub https://github.com/quantumlib/OpenFermion/pull/1101#issuecomment-3146940050, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ34Y4KMI7AYUTNZCP7WZWL3LV4MTAVCNFSM6AAAAACCUWIII2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNBWHE2DAMBVGA . You are receiving this because you were mentioned.Message ID: @.***>

hofong428 avatar Aug 03 '25 05:08 hofong428