Support common notations in circuit_to_latex_using_qcircuit - PR for Issue #4685

[NikolaiLong]

PR for: https://github.com/quantumlib/Cirq/issues/4685

[codecov[bot]]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 98.12%. Comparing base (5c198ce) to head (3898f9e). :warning: Report is 451 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7151      +/-   ##
==========================================
+ Coverage   97.88%   98.12%   +0.24%     
==========================================
  Files        1085     1093       +8     
  Lines       95184    95596     +412     
==========================================
+ Hits        93174    93808     +634     
+ Misses       2010     1788     -222     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[NikolaiLong]

I apologize for how long it's taking to resolve formatting issues.

[mhucka]

I apologize for how long it's taking to resolve formatting issues.

No need for apologies at all!

What would make it easier to catch format issues these earlier? I know from experience that waiting for CI checks to tell me about niggling issues becomes frustrating pretty quickly. Are there ways of making the contribution process easier on people?

[NikolaiLong]

I see, you're right, running a tool before pushing a commit would speed up this process a lot.

I found the /benchmarks and /check directories in Cirq, and I'm assuming the ./check/all script runs all the checks for formatting. I tried running the script in my virtual environment - and out of it - after setting the script's permissions to execute (chmod +x ./check/all); however, I can't get the script to run. Whenever I attempt (./check/all), my system tries to simply open the file rather than run it.

Is there any step that I'm missing? I really appreciate the response @mhucka.

[mhucka]

@NikolaiLong what is the operating system you're using?

[NikolaiLong]

@mhucka I'm on Windows using PowerShell (Administrator).

[mhucka]

Ah, hmm, that's probably why they are not working as expected. They were written with the assumption of Linux/MacOS/Unix systems (c.f. https://quantumai.google/cirq/dev/development).

The only thing that comes to mind right now is to try the Windows Subsystem for Linux (WSL). I haven't used it myself, but reading about it, it's supposed to provide a Bash shell, so maybe those scripts will run there.

Would the WSL be an option? I don't know what versions of Windows support it or what other impliications it has.

[NikolaiLong]

Yes! I have WSL installed on my machine already. I'll use it for the next issue I work on, that'll probably fix this problem. Thanks for helping get to the bottom of this @mhucka!

[mhucka]

@NikolaiLong very sorry for the delay reviewing this. I seem to be unable to update this branch due to some permissions issue; I don't think it's anything you did or can fix, but I need to figure out what's going on. Planning on working on that and the review today or tomorrow. Update 2025-04-07: never mind; this button was something shown by the extension Refined Github I installed in my browser not long ago. I've turned off this feature so that it doesn't confuse me in the future.

[pavoljuhas]

I think this needs a bit more time to converge. As a contrib function it is also less critical to appear in next stable release which we want to complete ASAP. Let us revisit this after 1.5.0.

[github-actions[bot]]

This pull request has been automatically labeled as stale because 90 days have passed without comments or other activity. If no further activity occurs and the status/stale label is not removed by a maintainer within 60 days, this pull request will be closed. If you would like to restore its active status, please leave a comment here; doing so will cause the staleness handler to remove the label.

If you have questions or feedback about this process, we welcome your input. You can open a new issue to let us know (please also reference this issue there, for continuity), or reach out to the project maintainers at [email protected].

[mhucka]

@NikolaiLong would you let us know what is the status of this work? Are you interested in continuing, or should we close this?

[mhucka]

Closing due to inactivity and nonresponse.