Cirq icon indicating copy to clipboard operation
Cirq copied to clipboard

Fix testing for example notebooks

Open balopat opened this issue 3 years ago • 2 comments

We should lift the fidelity estimation notebook into our regular docs/tutorials folder.

Currently it's also untestable as it fails with:

Exception encountered at "In [2]":
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-2-8c00c9255350> in <module>
      2 import cirq
      3 from cirq.contrib.svg import SVGCircuit
----> 4 import examples.direct_fidelity_estimation as dfe
      5 
      6 qubits = cirq.LineQubit.range(3)

ModuleNotFoundError: No module named 'examples'

balopat avatar Nov 13 '20 05:11 balopat

@balopat Lifting the notebook is trivial, but where can the direct_fidelity_estimation.py file be put? This is the only place where an import examples.Something is done? I don't see a good place for it to be imported. However, I don't know whether removing the notebook is an option either.

unaiic avatar Mar 27 '21 16:03 unaiic

Also affecting stabilizer_code if #3935 gets accepted.

tonybruguier avatar Apr 08 '21 03:04 tonybruguier

All of these notebooks are automatically tested in the nightly docs build. I think this bug is obsolete.

dstrain115 avatar Feb 07 '24 19:02 dstrain115