qgrid icon indicating copy to clipboard operation
qgrid copied to clipboard

qgrid 1.2.0 and 1.3.0 is not available on jsdelivr.com or unpkg.com

Open DonJayamanne opened this issue 5 years ago • 7 comments

Similar to issue https://github.com/quantopian/qgrid/issues/302

We Python extension in VS Code are adding support for ipywidgets in our implementation of notebooks. We found that users installing the latest version of qgrid from pypi will never be able to get this working as the script isn't available on cdn for the latest versions.

Thanks.

DonJayamanne avatar Apr 20 '20 16:04 DonJayamanne

I believe this was addressed in https://github.com/quantopian/qgrid/pull/288

Upkg: https://unpkg.com/[email protected]/src/index.js Jsdelivr: https://www.jsdelivr.com/package/npm/qgrid2

Conda-forge is still an open issue for now.

gerrymanoim avatar Apr 20 '20 18:04 gerrymanoim

Upkg: unpkg.com/[email protected]/src/index.js

I'm referring to 1.3.0 not 1.1.3.

DonJayamanne avatar Apr 22 '20 23:04 DonJayamanne

Apologies - I'm not sure exactly what you mean.

Qgrid, the python package, is available on pypi: https://pypi.org/project/qgrid/ (1.3.1). Qgrid2, the supporting npm package, is available on npm: https://www.npmjs.com/package/qgrid2

gerrymanoim avatar Apr 23 '20 14:04 gerrymanoim

Hmm, that will be an issue. Based on the docs here this will not work for those trying to add support for qgrid outside of jupyter notebooks/lab. Basically the name of the module & version must match the name of the js module & version.

Ie we'll end up looking for https://unpkg.com/[email protected]/dist/index.js

We can make an exception for qgrid and hardcode the js package name to be qgrid2, however the versions must match.

@jasongrout Do you have any recommendations here. Or am I missing something here?

DonJayamanne avatar Apr 23 '20 16:04 DonJayamanne

cc @richafrank @jbredeche - can we push the new js back to npm/qgrid and get the versions aligned?

gerrymanoim avatar Apr 23 '20 17:04 gerrymanoim

I would recommend adding publishing the package to npm as a step in the publish CI workflow. That way we don't have to rely on the maintainers to remember to manually publish the releases to npm.

https://github.com/quantopian/qgrid/actions?query=workflow%3A%22Publish+Python+%F0%9F%90%8D+distributions+%F0%9F%93%A6+to+PyPI%22

thedanielforum avatar Jun 08 '20 07:06 thedanielforum

Hello, I recently found qgrid is so helpful in my exploratory data analysis workflow but unfortunately is incompatible with in-vscode jupyter notebook (even with jsdelivr.com and unpkg.com settings). It's good to know that if anyon is tracking this issue, many thanks.

harrisliuwk avatar Nov 06 '20 03:11 harrisliuwk