Evan Jacobs comments

Results 415 comments of


                                            Evan Jacobs

Set type of package to module

@leebyron have you tested this change in a normal cjs project?

First line indentation ignored / whole indented string erroneously considered codeblock

@jshado1 Something like this might be useful: https://github.com/zspecza/common-tags#stripindent

WebpackError: TypeError: Cannot read property 'replace' of undefined

I’d recommend doing an || ‘’ in places where you think the content might be undefined to work around this. We can add some handling in the library as well....

WebpackError: TypeError: Cannot read property 'replace' of undefined

Can keep it open, thanks!

I there a way to make img tags render as top level elements

I played with this originally but most people didn't seem to like how it worked and I got some issues around it.

I there a way to make img tags render as top level elements

You'd want to use `React.Children.toArray(props.children).some` https://reactjs.org/docs/react-api.html

Possibly redundant regex

Try removing it and see if the tests pass, heh.

Extend `namedCodesToUnicode` to allow own HTML character references

This is definitely something I'm open to adding if you'd like to make an RFC or open a PR!

Is it possible to add support for other markdown syntax, such as || text || for spoilers?

Adding extensibility is definitely possible - need to think on what the best/least confusing implementation strategy would be.

Is it possible to add support for other markdown syntax, such as || text || for spoilers?

I haven’t worked on this project in a while… I’d be open to a PR that exposes an `extendRules(rules, helpers) => rules` callback to append new rules to the existing...