squiggle icon indicating copy to clipboard operation
squiggle copied to clipboard

Tooltip actions

Open berekuk opened this issue 1 year ago • 3 comments

This PR adds the contextual dropdown menu to editor tooltips: Screenshot 2024-06-13 at 14 17 07

TODO before this can be merged:

  • fix the critical problem with the menu disappearing if the pointer is outside of the tooltips box (looking through hoverTooltip source code, it doesn't seem possible to customize, so we'd have to fork hoverTooltip implementation from Codemirror)
    • alternatively, we could replace the dropdown menu with a set of buttons that don't bleed outside of the tooltip box; but we're going to have many actions, eventually, so this won't scale
  • implement more useful actions - one that I particularly care about is "add documentation", which should open a modal window for editing the markdown for @doc tag
  • not a blocker, but it would be nice to have these actions available from the viewer side of the playground too (this would require exposing the entire EditorView object outside of <CodeEditor>, but that shouldn't be difficult)

berekuk avatar Jun 13 '24 17:06 berekuk

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Jun 13, 2024 5:26pm
quri-ui ✅ Ready (Inspect) Visit Preview Jun 13, 2024 5:26pm
squiggle-components ✅ Ready (Inspect) Visit Preview Jun 13, 2024 5:26pm
squiggle-website ✅ Ready (Inspect) Visit Preview Jun 13, 2024 5:26pm

vercel[bot] avatar Jun 13 '24 17:06 vercel[bot]

🦋 Changeset detected

Latest commit: 9eb71ec439d1d241cd1eb9751bee54f2409c6230

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@quri/squiggle-components Patch
@quri/versioned-squiggle-components Patch
vscode-squiggle Patch
@quri/squiggle-lang Patch
@quri/prettier-plugin-squiggle Patch
@quri/squiggle-textmate-grammar Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 13 '24 17:06 changeset-bot[bot]

Note: this PR is done on top of #3314, can switch to main after that one is merged.

berekuk avatar Jun 13 '24 17:06 berekuk