multitenant-oauth2-spring-boot-starter icon indicating copy to clipboard operation
multitenant-oauth2-spring-boot-starter copied to clipboard

Added Build Script and Dependabot, Updated spring boot version to 3.2.3

Open garvit-joshi opened this issue 1 year ago • 6 comments

@jomatt , I have removed versions from the pom as it can be taken from the spring boot starter. Dependabot is configured for automatically creating a PR whenever a new version is available.

garvit-joshi avatar Feb 07 '24 07:02 garvit-joshi

Also, Can we have the versions of this as same as spring boot starter. Such as multitenant-oauth2-spring-boot-starter version 3.2.2 should have spring boot version 3.2.2.

garvit-joshi avatar Feb 07 '24 07:02 garvit-joshi

Build Script Logs: https://github.com/garvit-joshi/multitenant-oauth2-spring-boot-starter/actions/runs/7811077921

garvit-joshi avatar Feb 07 '24 08:02 garvit-joshi

@jomatt Any Update?

garvit-joshi avatar Feb 10 '24 19:02 garvit-joshi

@garvit-joshi thx a lot for opening this PR and contributing to the library!

I had the same idea regarding synchronizing the version in the beginning, but then decided against it because I had to publish various releases for the same Spring Boot version. I think in general it's a good idea to use the same version as Spring Boot. However, how would you handle hotfix versions, e.g. if we need to provide a fix for version 3.2.2 - how do you suggest to version it?

Also, it would be really helpful to automate the publishing of the build artifacts to Maven central. This is already on my todo list, but so far I did not find the time to add it. Would you be available to add this to the GH workflows?

jomatt avatar Feb 11 '24 12:02 jomatt

Hi, I found one workaround for the versioning: Oracle has versioning different from Semver where the versioning is the form of w.x.y.z. We can make the versions 3.2.2.x where x is the patch version. Oracle Maven Packages: here.

Sure, I will try to add a new workflow for maven publishing when I get time to experiment with maven package publishing.

garvit-joshi avatar Feb 17 '24 05:02 garvit-joshi

Hi @jomatt ,

Apologies for the delay. I have made few chages, however i am not that confident on releasing to maven workflow, as I could not test it.

Could you please check if i am missing something here

garvit-joshi avatar Mar 10 '24 12:03 garvit-joshi