quantiacs-python icon indicating copy to clipboard operation
quantiacs-python copied to clipboard

Added support for python3

Open tuangeek opened this issue 8 years ago • 8 comments

Changes to print.

  • added parentheses to print statements in files:
    • quantiacsToolbox/quantiacsToolbox.py
    • sampleSystems/heikinAshi.py

Added import for urllib in python3

  • try to import urllib for python3 and python2
    • quantiacsToolbox/quantiacsToolbox.py

Added import for Tkinter in python3

  • try to import Tkinter for python3 and python2
    • quantiacsToolbox/quantiacsToolbox.py

dataFile write uses attribute "wb" instead of "w"

    • quantiacsToolbox/quantiacsToolbox.py

tuangeek avatar Sep 04 '17 15:09 tuangeek

Just finished doing these very same sort of edits myself during setup. Came over to post them up for other Python3 users. Nice to see someone has done it already. Awesome work! 👍

bugwhisperer-dev avatar Sep 28 '17 10:09 bugwhisperer-dev

@tuangeek @flygeneticist 👍 Thanks for the great input. We understand the importance for adding support for Python 3, it is our plan to add it to the next version of QuantiacsToolbox.

For now we are focusing on more time-sensitive projects such as improving our production system, please feel free to post any thoughts, we appreciate them very much.

YalaTest avatar Oct 20 '17 22:10 YalaTest

@YalaTest If the work is done and it passes, what's to stop the team from merging this? Is it incompatible with the latest stuff? Do we just need to add some tests to check for backwards compatibility? Since the code is there and we're all making the same changes, please let us save you some future work.

dannypurcell avatar Feb 14 '18 03:02 dannypurcell

Hi @dannypurcell

Thanks for the comment.

Is it incompatible with the latest stuff? I'm not sure what you mean by the latest stuff here, but we are trying to refactor the code and adding some new features, on top of porting from Py 2 to 3.

Do we just need to add some tests to check for backwards compatibility? The lack of test cases is one of the things that are slowing us down. If you would like help us create some test cases, we'll appreciate it greatly.

We are considering making a beta version of the toolbox that will support 2 and 3 while we are developing new features.

YalaTest avatar Feb 17 '18 00:02 YalaTest

Still quite new to Python and having got used to Py 3 found that Quantiacs only supports Py 2 any chance we could get the Beta version soon as I'd really like to explore the site and the available code, thanks

Chris-Mayhead avatar Mar 03 '18 08:03 Chris-Mayhead

I wonder how the proposed, manual, changes compare to simply running the "2to3" tool that ships with Python 3? At the very least, such a comparison should be made.

jesperkristensen58 avatar Mar 06 '18 01:03 jesperkristensen58

Any updates on this? Currently looking into quantiacs and using python 3 would be a big plus.

rminderhoud avatar May 24 '18 23:05 rminderhoud

Is there any news on this subject

JeancarloBarrios avatar Jun 26 '18 21:06 JeancarloBarrios