bogrep icon indicating copy to clipboard operation
bogrep copied to clipboard

Enable markdown mode

Open quambene opened this issue 1 year ago • 3 comments

To enable markdown mode again, the following needs to be fixed:

  1. panics for bogrep <pattern> --mode markdown (cf. https://github.com/quambene/bogrep/issues/30) :heavy_check_mark:
  2. conversion from HTML to markdown is leading to >1 GB markdown files for a few urls (while plaintext files are still a few kilobytes)

quambene avatar Nov 16 '23 23:11 quambene

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (0c9cd10) 91.59% compared to head (5611298) 91.34%.

Files Patch % Lines
src/cache.rs 0.00% 7 Missing :warning:
src/cmd/search.rs 60.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   91.59%   91.34%   -0.25%     
==========================================
  Files          26       26              
  Lines        3401     3410       +9     
==========================================
  Hits         3115     3115              
- Misses        286      295       +9     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 16 '23 23:11 codecov[bot]

I just tried markdown mode and it still hangs after downloading some content.

mattmartini avatar Nov 17 '23 01:11 mattmartini

that's the second part (see description above) which is not fixed yet

quambene avatar Nov 17 '23 01:11 quambene