AudioMeter icon indicating copy to clipboard operation
AudioMeter copied to clipboard

Any interest a minimal (ish?) PR update to API Level / toolchain etc?

Open krc opened this issue 1 year ago • 0 comments

I do NOT know what I am doing for the most part, but I messed around a bit and did roughly the following:

Updated Gradle to 8.9 Change Gradle repos (jcenter gone, etc) Updated Java compile version to 21 Updated com.android.support:appcompat-v7 to 28.0.0 Updated com.android.support:design to 28.0.0 Set API level to 34 (A14), min to 28 (A9) Bumped to display version 1.3, version code 4

Change/add/delete syntax as need for compatibility - it's not that much really e.g. compileSdkVersion -> compileSdk (etc) delete rootProject.buildDir -> delete rootProject.layout.buildDirectory added languageVersion = JavaLanguageVersion.of(21) added android:exported to android manifest added namespace for modules / removed package from android manifest

(all noted from Android Studio tips/errors)

I did not update/change anything to do with JUnit, espresso, proguard, nor any actual Java code changes...

Tested (minimally) in Android Studio emu: "Medium Phone API 35", "Pixel 4 API 30", "Small Phone API 28" Tested with USB attached phone Pixel 6a, Android 14/API 34 - Graphene OS On all of those, it runs, seems to work (correctly? well louder things go higher, so), help/about/options work

I didn't try to build/install an APK (used streaming or whatever it is from Android Studio) Oh and also removed and gitignored some .idea/ files that... probably shouldn't be or at least don't need to be in there?

Anyway I mostly wanted something that could install and run without warnings, so I just did this.

If you are not interested (or my changes are too messy/clumsy/bad & wrong LOL), that is fine. In that case I will probably just make an APK for myself? I could also fork and see about publishing to fdroid, but eh. Seems like a lot of work lol

If you are interested, I can make a PR... er, might need some help to create it correctly, I have done only one PR ever I think.

Regardless, thanks for writing this in the first place!

krc avatar Oct 16 '24 18:10 krc