Dr. Quinten Stokkink
Dr. Quinten Stokkink
Naively implementing these new messages turns the `community.py` code into a complete mess. I'll take some time to (hopefully) figure out a good way to combine the old and the...
Update on the current best plan to make sure the new-style introduction messages don't spaghettify the community logic: Both the IntroductionRequest and IntroductionResponse have unused bits (in the `advice` and...
With #913 merged we now move into the final phase: porting the DHTCommunity and the TunnelCommunity. With that, after an entire year of development, my involvement with this issue is...
Once the last component has been ported, the configuration should also support specifying the address and port of the IPv6 interface. https://github.com/Tribler/py-ipv8/blob/76da077fef59225cfd12937880ff8f7a85e60b6a/ipv8_service.py#L79-L80 In turn, the documentation should also be updated:...
@Solomon1732 The only Community left to port is the anonymization Community (the `TunnelCommunity`). We have assigned this to its original author @egbertbouman as it is quite some complex logic/cryptography that...
_[Memo]_ The test suite can be run using IPv6 fake addresses by changing the following code from `"UDPv4Address" ` to `"UDPv6Address" `. https://github.com/Tribler/py-ipv8/blob/fcf2c7971a9b3d91c4dfb159f6e17f68c081f1d0/ipv8/test/mocking/endpoint.py#L74-L76
We should probably also run the entire test suite on each build environment twice: for IPv4 and IPv6. For reference: the tests use IPv4 (default) if `ipv8.test.mocking.endpoint.ADDRESS_TYPE = "UDPv4Address"` and...
We should probably also make sure to test all supported test runners: `unittest` (which is the most important), `nose` and `pytest`. I'm not sure if other runners are (still) supported,...
Based on the amount of time taken by the Tribler PR tests (using GitHub Actions), unit testing would take in the order of minutes. A full run of all supported...
@drew2a thanks for the suggestion, I gave option 3 some serious thought over the last few days. My conclusion is that depending on draft/ready (which can be controlled by the...